[PR #2702] [MERGED] [PM-2658] Settings Reorganization feature #45354

Closed
opened 2026-04-26 12:38:05 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2702
Author: @fedemkr
Created: 8/17/2023
Status: Merged
Merged: 9/27/2023
Merged by: @fedemkr

Base: masterHead: vault/pm-2658/feature-settings-reorganization


📝 Commits (10+)

  • c5aa4bf [PM-2658] Settings Reorganization Init (#2697)
  • b632c48 [PM-3512] Settings Appearance (#2703)
  • 2d7ade0 Merge branch 'master' into vault/pm-2658/feature-settings-reorganization
  • a635d54 [PM-3510] Implement Account Security Settings view (#2714)
  • 0eeef33 Merge branch 'master' into vault/pm-2658/feature-settings-reorganization
  • ab01a2d Merge branch 'master' into vault/pm-2658/feature-settings-reorganization
  • 1ac5d46 PM-3511 Implemented autofill settings view (#2735)
  • 57da45c Merge branch 'master' into vault/pm-2658/feature-settings-reorganization
  • 14d4d7f [PM-3695] Add Connect to Watch to Other settings (#2736)
  • 43a212b [PM-3693] Clear old Settings approach (#2737)

📊 Changes

91 files changed (+3620 additions, -2356 deletions)

View changed files

📝 src/Android/Android.csproj (+8 -0)
📝 src/Android/MainActivity.cs (+1 -1)
📝 src/Android/MainApplication.cs (+2 -0)
src/Android/Resources/drawable/empty_login_requests.xml (+41 -0)
src/Android/Resources/drawable/empty_login_requests_dark.xml (+41 -0)
📝 src/Android/Services/DeviceActionService.cs (+38 -0)
📝 src/App/Abstractions/IDeviceActionService.cs (+5 -0)
📝 src/App/App.csproj (+2 -9)
📝 src/App/App.xaml.cs (+2 -2)
src/App/Controls/ExternalLinkItemView.xaml (+29 -0)
src/App/Controls/ExternalLinkItemView.xaml.cs (+31 -0)
src/App/Controls/Settings/BaseSettingControlView.cs (+25 -0)
src/App/Controls/Settings/SettingChooserItemView.xaml (+19 -0)
src/App/Controls/Settings/SettingChooserItemView.xaml.cs (+31 -0)
src/App/Controls/Settings/SwitchItemView.xaml (+19 -0)
src/App/Controls/Settings/SwitchItemView.xaml.cs (+45 -0)
📝 src/App/Pages/Accounts/HomePage.xaml.cs (+1 -1)
src/App/Pages/BaseModalContentPage.cs (+18 -0)
📝 src/App/Pages/BaseViewModel.cs (+23 -1)
📝 src/App/Pages/Generator/GeneratorPage.xaml.cs (+2 -1)

...and 71 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This is the merge of the Settings Reorganization feature branch into master.
Each individual PR on the branch has been reviewed and has screenshots.

Code changes

See individual PRs for context.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2702 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 8/17/2023 **Status:** ✅ Merged **Merged:** 9/27/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `vault/pm-2658/feature-settings-reorganization` --- ### 📝 Commits (10+) - [`c5aa4bf`](https://github.com/bitwarden/android/commit/c5aa4bf023b2b1fda1c982c3d3e498e2096295d1) [PM-2658] Settings Reorganization Init (#2697) - [`b632c48`](https://github.com/bitwarden/android/commit/b632c48f392077eb21cfa8fe8a4aa9ce483f6e4c) [PM-3512] Settings Appearance (#2703) - [`2d7ade0`](https://github.com/bitwarden/android/commit/2d7ade0b5a3d24feacca323367a1c229a7309007) Merge branch 'master' into vault/pm-2658/feature-settings-reorganization - [`a635d54`](https://github.com/bitwarden/android/commit/a635d54deb20ba89a1389c68774993754d09ab5f) [PM-3510] Implement Account Security Settings view (#2714) - [`0eeef33`](https://github.com/bitwarden/android/commit/0eeef3310a0ff8b71fc69bde0ef75716f0201a04) Merge branch 'master' into vault/pm-2658/feature-settings-reorganization - [`ab01a2d`](https://github.com/bitwarden/android/commit/ab01a2d2249cc1c29934e504d6c071f2d2257969) Merge branch 'master' into vault/pm-2658/feature-settings-reorganization - [`1ac5d46`](https://github.com/bitwarden/android/commit/1ac5d46f171e0834e82470b53c40ebe7b16515d3) PM-3511 Implemented autofill settings view (#2735) - [`57da45c`](https://github.com/bitwarden/android/commit/57da45c4ebbae9e50a638653df969e68662ca891) Merge branch 'master' into vault/pm-2658/feature-settings-reorganization - [`14d4d7f`](https://github.com/bitwarden/android/commit/14d4d7fa17219bb9efedf35751b26073e560cd70) [PM-3695] Add Connect to Watch to Other settings (#2736) - [`43a212b`](https://github.com/bitwarden/android/commit/43a212b7c1e7b398bfba55dcf0add3966ce37ad3) [PM-3693] Clear old Settings approach (#2737) ### 📊 Changes **91 files changed** (+3620 additions, -2356 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+8 -0) 📝 `src/Android/MainActivity.cs` (+1 -1) 📝 `src/Android/MainApplication.cs` (+2 -0) ➕ `src/Android/Resources/drawable/empty_login_requests.xml` (+41 -0) ➕ `src/Android/Resources/drawable/empty_login_requests_dark.xml` (+41 -0) 📝 `src/Android/Services/DeviceActionService.cs` (+38 -0) 📝 `src/App/Abstractions/IDeviceActionService.cs` (+5 -0) 📝 `src/App/App.csproj` (+2 -9) 📝 `src/App/App.xaml.cs` (+2 -2) ➕ `src/App/Controls/ExternalLinkItemView.xaml` (+29 -0) ➕ `src/App/Controls/ExternalLinkItemView.xaml.cs` (+31 -0) ➕ `src/App/Controls/Settings/BaseSettingControlView.cs` (+25 -0) ➕ `src/App/Controls/Settings/SettingChooserItemView.xaml` (+19 -0) ➕ `src/App/Controls/Settings/SettingChooserItemView.xaml.cs` (+31 -0) ➕ `src/App/Controls/Settings/SwitchItemView.xaml` (+19 -0) ➕ `src/App/Controls/Settings/SwitchItemView.xaml.cs` (+45 -0) 📝 `src/App/Pages/Accounts/HomePage.xaml.cs` (+1 -1) ➕ `src/App/Pages/BaseModalContentPage.cs` (+18 -0) 📝 `src/App/Pages/BaseViewModel.cs` (+23 -1) 📝 `src/App/Pages/Generator/GeneratorPage.xaml.cs` (+2 -1) _...and 71 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> This is the merge of the Settings Reorganization feature branch into master. Each individual PR on the branch has been reviewed and has screenshots. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> See individual PRs for context. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:38:05 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45354