github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 05:02:48 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1000] [MERGED] [KnownUsernameField] Compatibility with more browsers #2702

New Issue
Closed
opened 2025-11-26 23:22:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1000
Author: @contribucious
Created: 6/30/2020
Status: ✅ Merged
Merged: 7/1/2020
Merged by: @mpbw2

Base: master ← Head: KnownUsernameField--browser-compatibility

📝 Commits (1)

  • fb9249e [KnownUsernameField] Compatibility with more browsers

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+3 -1)

📄 Description

Context

Currently, the new system allowing "email/username" field detection without "password" field, which uses the accessibility service, only works well with some browsers like Chrome.

Indeed, if the subdomain is specific like signin.example.com: no problem!
But if it's www.example.com, Bitwarden (with current entries) will assume that the browser will hide this part for comparison. (This is a new trend in browsers.)

Problem

This is only the case in some browsers (currently: Chrome, Firefox beta, etc.).

Problem (illustration with Amazon but same with PayPal for ex.)

View me ...   
new KnownUsernameField("amazon.com", "signin", "ap_email_login"),
[...]
if (KnownUsernameFields.ContainsKey(uriKey))

➡️ Chrome ✔️ (match, because Chrome hides www.)

View me ...

 
Screenshot_1593288746

>>> uriKey: amazon.com, uriLocalPath: /ap/signin, viewId: ap_email_login

➡️ Firefox for Android 68.x ❌ (don't match, because Firefox shows www.)

View me ...

 
Screenshot_1593535204

>>> uriKey: www.amazon.com, uriLocalPath: /ap/signin, viewId: ap_email_login

Solution

It's therefore advisable to remove the www. part on the Bitwarden side before comparison.

This PR allows the use of this system with:

➡️ Please note: The logged uriKey value will now be the one to be used in practice. So, will always return the version without www. from now on.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1000 **Author:** [@contribucious](https://github.com/contribucious) **Created:** 6/30/2020 **Status:** ✅ Merged **Merged:** 7/1/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `KnownUsernameField--browser-compatibility` --- ### 📝 Commits (1) - [`fb9249e`](https://github.com/bitwarden/android/commit/fb9249e627d82fb87d367e1a0efa117e24169818) [KnownUsernameField] Compatibility with more browsers ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+3 -1) </details> ### 📄 Description ### Context Currently, the [new system](https://github.com/bitwarden/mobile/pull/880) allowing "email/username" field detection without "password" field, which uses the accessibility service, only works well with some browsers like Chrome. Indeed, if the subdomain is specific like `signin.`example.com: no problem! But if it's `www.`example.com, Bitwarden (with current entries) will assume that the browser will hide this part for comparison. _(This is a new trend in browsers.)_ ### Problem This is only the case in some browsers (currently: [Chrome](https://user-images.githubusercontent.com/4764956/86173097-bbf50a00-bb1f-11ea-8ee0-aa776e0c7b0c.png), [Firefox beta](https://user-images.githubusercontent.com/4764956/86173122-c6170880-bb1f-11ea-8fb1-cc9575e1a38b.png), etc.). ### Problem (illustration with Amazon but same with PayPal for ex.) <details> <summary>View me ...</summary> &nbsp; ```csharp new KnownUsernameField("amazon.com", "signin", "ap_email_login"), [...] if (KnownUsernameFields.ContainsKey(uriKey)) ``` :arrow_right: **Chrome** :heavy_check_mark: _(match, because Chrome hides `www.`)_ <details> <summary>View me ...</summary> &nbsp; ![Screenshot_1593288746](https://user-images.githubusercontent.com/4764956/86159292-606c5180-bb0a-11ea-95f9-2c6532aca0e8.png) ``` >>> uriKey: amazon.com, uriLocalPath: /ap/signin, viewId: ap_email_login ``` </details> :arrow_right: **Firefox for Android 68.x** :x: _(don't match, because Firefox shows `www.`)_ <details> <summary>View me ...</summary> &nbsp; ![Screenshot_1593535204](https://user-images.githubusercontent.com/4764956/86159359-7e39b680-bb0a-11ea-81fa-eeaa5caf4967.png) ``` >>> uriKey: www.amazon.com, uriLocalPath: /ap/signin, viewId: ap_email_login ``` </details> </details> ### Solution It's therefore advisable to remove the `www.` part on the Bitwarden side before comparison. **This PR allows the use of this system with:** - [Older versions of Chrome](https://user-images.githubusercontent.com/4764956/86160935-d2459a80-bb0c-11ea-9d8d-e6436816dba8.png) (+ forks) :heavy_check_mark: - [Firefox for Android <= 68.x](https://user-images.githubusercontent.com/4764956/86160842-acb89100-bb0c-11ea-9de1-64e7486f40ac.png) (+ forks) :heavy_check_mark: :bulb: _Current stable version at the time of writing: [68.10.0](https://www.mozilla.org/en-US/firefox/android/68.10.0/releasenotes/) ([68.9.0](https://play.google.com/store/apps/details?id=org.mozilla.firefox) on Google Play Store)_ - Some alternative browsers :heavy_check_mark: :arrow_right: **Please note:** The logged `uriKey` value will now be the one to be used in practice. So, will always return the version without `www.` from now on. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2702
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?