github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 13:36:39 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3931] [MERGED] PM-12297: Add accessibility service alert for autofill tile #4534

New Issue
Closed
opened 2025-11-26 23:46:04 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:46:04 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3931
Author: @david-livefront
Created: 9/17/2024
Status: ✅ Merged
Merged: 9/18/2024
Merged by: @david-livefront

Base: main ← Head: PM-12297-accessibility-alert

📝 Commits (1)

  • 498208b PM-12297: Add accessibility service alert for autofill tile

📊 Changes

1 file changed (+15 additions, -0 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/tiles/BitwardenAutofillTileService.kt (+15 -0)

📄 Description

🎟️ Tracking

PM-12297

📔 Objective

This PR adds a alert dialog to the BitwardenAutofillTileService whenever a user attempts to invoke the service but the BitwardenAccessibilityService is not enabled.

📸 Screenshots

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3931 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 9/17/2024 **Status:** ✅ Merged **Merged:** 9/18/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-12297-accessibility-alert` --- ### 📝 Commits (1) - [`498208b`](https://github.com/bitwarden/android/commit/498208bc4b7b6ce9f8e0a5652bd9ae0391360e86) PM-12297: Add accessibility service alert for autofill tile ### 📊 Changes **1 file changed** (+15 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/tiles/BitwardenAutofillTileService.kt` (+15 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-12297](https://bitwarden.atlassian.net/browse/PM-12297) ## 📔 Objective This PR adds a alert dialog to the `BitwardenAutofillTileService` whenever a user attempts to invoke the service but the `BitwardenAccessibilityService` is not enabled. ## 📸 Screenshots <video src="https://github.com/user-attachments/assets/0963f4e8-f5d3-4226-9328-647dc9225330" width="300" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-12297]: https://bitwarden.atlassian.net/browse/PM-12297?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:46:04 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4534
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?