github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-21 22:00:42 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2983] [PM-6077] Separated Android and iOS HybridWebViewHandler so that it can be used in iOS.Core #3931

New Issue
Closed
opened 2025-11-26 23:38:42 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:38:42 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/2983

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

We want to separated Android and iOS HybridWebViewHandler so that it can be used in iOS.Core

Code changes

  • HybridWebViewHandler.cs: Removed the "shared" partial class and moved the iOS implementation from App to iOS.Core project.
    The code that was in the shared partial class was added to both Android and iOS implementations.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/2983 **State:** closed **Merged:** Yes --- ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective We want to separated Android and iOS `HybridWebViewHandler` so that it can be used in `iOS.Core` ## Code changes * **HybridWebViewHandler.cs:** Removed the "shared" partial class and moved the iOS implementation from `App` to `iOS.Core `project. The code that was in the shared partial class was added to both Android and iOS implementations. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:38:42 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3931
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?