github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2620] [MERGED] [PM-3030] Fixing wrong ID on CipherDetailsPage for Login items #45288

New Issue
Closed
opened 2026-04-26 12:32:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:32:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2620
Author: @ifernandezdiaz
Created: 7/14/2023
Status: ✅ Merged
Merged: 7/16/2023
Merged by: @ifernandezdiaz

Base: master ← Head: PM-3030/fixing-discrepancy-on-Show-Value-button-ids

📝 Commits (1)

  • f188d56 Fixing show value id button

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/App/Pages/Vault/CipherDetailsPage.xaml (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

We added a different ID to the View Password button on CipherDetailsPage (for Login items), causing issues in our tests. This PR aims to replace the ID with the right one.

Code changes

  • ** CipherDetailsPage.xaml:** Updating AutomationID for View Password button

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2620 **Author:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Created:** 7/14/2023 **Status:** ✅ Merged **Merged:** 7/16/2023 **Merged by:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Base:** `master` ← **Head:** `PM-3030/fixing-discrepancy-on-Show-Value-button-ids` --- ### 📝 Commits (1) - [`f188d56`](https://github.com/bitwarden/android/commit/f188d564c16c6d7a70bfe772c254d0075da4c149) Fixing show value id button ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/CipherDetailsPage.xaml` (+1 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective We added a different ID to the View Password button on CipherDetailsPage (for Login items), causing issues in our tests. This PR aims to replace the ID with the right one. ## Code changes * ** CipherDetailsPage.xaml:** Updating AutomationID for View Password button ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:32:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45288
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?