github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #857] [MERGED] Prevent actionsheet command execution if vault is locked #2620

New Issue
Closed
opened 2025-11-26 23:21:48 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:21:48 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/857
Author: @mpbw2
Created: 4/28/2020
Status: ✅ Merged
Merged: 4/28/2020
Merged by: @mpbw2

Base: master ← Head: bugfix-actionsheet

📝 Commits (1)

  • 01a71e8 Prevent actionsheet command execution if vault is locked

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 src/App/Utilities/AppHelpers.cs (+6 -1)

📄 Description

Actionsheets cannot be programmatically dismissed, so instead we're checking the lock state before executing the selected action. If the vault is locked, a simple "Vault is Locked" toast is shown, and the sheet is dismissed to make way for the unlock screen that is already visible.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/857 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 4/28/2020 **Status:** ✅ Merged **Merged:** 4/28/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-actionsheet` --- ### 📝 Commits (1) - [`01a71e8`](https://github.com/bitwarden/android/commit/01a71e890e7eec05d458e5787a0b5ac8b02a04c9) Prevent actionsheet command execution if vault is locked ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Utilities/AppHelpers.cs` (+6 -1) </details> ### 📄 Description Actionsheets cannot be programmatically dismissed, so instead we're checking the lock state before executing the selected action. If the vault is locked, a simple "Vault is Locked" toast is shown, and the sheet is dismissed to make way for the unlock screen that is already visible. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:48 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2620
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?