github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 05:20:24 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1768] [MERGED] remove datepicker style workaround #44713

New Issue
Closed
opened 2026-04-26 11:56:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 11:56:41 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1768
Author: @jlf0dev
Created: 2/11/2022
Status: ✅ Merged
Merged: 2/11/2022
Merged by: @jlf0dev

Base: master ← Head: bug/datepicker-style-issue

📝 Commits (1)

  • 0495a15 remove datepicker style workaround

📊 Changes

1 file changed (+0 additions, -13 deletions)

View changed files

📝 src/iOS.Core/Renderers/ExtendedDatePickerRenderer.cs (+0 -13)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

We had a workaround for DatePicker styling that targeted iOS 13.2 and above. This workaround was actually supposed to be targeting 14.0 and above, so was throwing an error on anything between 13.2 and 14.0.

Since we have upgraded to Xamarin 5.0.0.2125, we can remove this as Xamarin has fixed the issue

Code changes

  • src/iOS.Core/Renderers/ExtendedDatePickerRenderer.cs: Remove styling workaround

Testing requirements

DatePicker should continue working correctly. There are examples on the Settings and EditSend screens.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1768 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 2/11/2022 **Status:** ✅ Merged **Merged:** 2/11/2022 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `bug/datepicker-style-issue` --- ### 📝 Commits (1) - [`0495a15`](https://github.com/bitwarden/android/commit/0495a1570dcee8239874177df217aa98a13fbae3) remove datepicker style workaround ### 📊 Changes **1 file changed** (+0 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Core/Renderers/ExtendedDatePickerRenderer.cs` (+0 -13) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> We had a workaround for `DatePicker` styling that targeted iOS 13.2 and above. This workaround was actually supposed to be targeting 14.0 and above, so was throwing an error on anything between 13.2 and 14.0. Since we have upgraded to Xamarin 5.0.0.2125, we can remove this as Xamarin has [fixed the issue](https://github.com/xamarin/Xamarin.Forms/pull/13344) ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/iOS.Core/Renderers/ExtendedDatePickerRenderer.cs:** Remove styling workaround ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> `DatePicker` should continue working correctly. There are examples on the Settings and EditSend screens. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 11:56:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#44713
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?