github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3778] [MERGED] [PM-9933] Update marketing copy #4411

New Issue
Closed
opened 2025-11-26 23:44:07 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:44:07 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3778
Author: @andrebispo5
Created: 8/19/2024
Status: ✅ Merged
Merged: 8/20/2024
Merged by: @andrebispo5

Base: main ← Head: pm-9933/update-copy

📝 Commits (10+)

  • 2ed3dde PM-10616 update start registration UI to match designs and support help click for server geolocation. Includes PM-10636 implementing padding needed for landscape.
  • 46153bb add feature flag check in landing vm
  • 0a6c9b5 fix test
  • 6df9250 use email verification flag
  • b4c4028 pr feedback, add some more tests
  • d3f06e5 mock fix
  • 7ba43f2 detekt
  • b793c3d [PM-9933] Update marketing copy
  • 032f658 Merge branch 'main' into pm-9933/update-copy
  • cc46b1e [PM-9933] Fix test

📊 Changes

3 files changed (+3 additions, -2 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt (+1 -1)
📝 app/src/main/res/values/strings.xml (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreenTest.kt (+1 -1)

📄 Description

Merge after https://github.com/bitwarden/android/pull/3751

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9933

📔 Objective

Update copy on marketing toggle.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3778 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 8/19/2024 **Status:** ✅ Merged **Merged:** 8/20/2024 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-9933/update-copy` --- ### 📝 Commits (10+) - [`2ed3dde`](https://github.com/bitwarden/android/commit/2ed3dde715a1b5b080aa274362dcd7f1c3431284) PM-10616 update start registration UI to match designs and support help click for server geolocation. Includes PM-10636 implementing padding needed for landscape. - [`46153bb`](https://github.com/bitwarden/android/commit/46153bb8dc074af97b21356fc62b819126522b0e) add feature flag check in landing vm - [`0a6c9b5`](https://github.com/bitwarden/android/commit/0a6c9b5e66f027f8d72748b220de054bc491aa72) fix test - [`6df9250`](https://github.com/bitwarden/android/commit/6df92501f5b7d98bc91a40453c6c6f519ae4ad70) use email verification flag - [`b4c4028`](https://github.com/bitwarden/android/commit/b4c402853171ee4c1e9f963168ad34da7a8b8245) pr feedback, add some more tests - [`d3f06e5`](https://github.com/bitwarden/android/commit/d3f06e583e9eaf1448653aee954a6e349d40b4fa) mock fix - [`7ba43f2`](https://github.com/bitwarden/android/commit/7ba43f26c4f35aff9c7108e44e0540636c168f0b) detekt - [`b793c3d`](https://github.com/bitwarden/android/commit/b793c3d3aee87a2a2aafd9fd9e5a3d2a8568a34a) [PM-9933] Update marketing copy - [`032f658`](https://github.com/bitwarden/android/commit/032f658a99879fb71d07a0b9bc5c31adbbfc118b) Merge branch 'main' into pm-9933/update-copy - [`cc46b1e`](https://github.com/bitwarden/android/commit/cc46b1e10e1d08366aa20ff5927b086e10127ba6) [PM-9933] Fix test ### 📊 Changes **3 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt` (+1 -1) 📝 `app/src/main/res/values/strings.xml` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreenTest.kt` (+1 -1) </details> ### 📄 Description Merge after https://github.com/bitwarden/android/pull/3751 ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-9933 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Update copy on marketing toggle. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> <img width="249" alt="image" src="https://github.com/user-attachments/assets/3943b41f-89ef-4f0a-9507-13e468cdce82"> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:44:07 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4411
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?