github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 21:10:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #4411] [MERGED] PM-15147 - MasterPasswordGuidanceScreen PR Cleanup #17681

New Issue
Closed
opened 2026-04-15 02:55:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:55:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4411
Author: @phil-livefront
Created: 12/3/2024
Status: ✅ Merged
Merged: 12/3/2024
Merged by: @phil-livefront

Base: main ← Head: phil/PM-15147-Design-Audit-Master-Password-Guidance-Screen-Cleanup

📝 Commits (2)

  • cc925c3 PR comments (remember view model and fix param order)
  • f0cf5f0 Merge branch 'main' into phil/PM-15147-Design-Audit-Master-Password-Guidance-Screen-Cleanup

📊 Changes

1 file changed (+8 additions, -6 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt (+8 -6)

📄 Description

🎟️ Tracking

PM-15147

📔 Objective

  • Address PR comments from previous PR
  • Remembering viewModel to prevent unnecessary recompositions and fix order of function parameters

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4411 **Author:** [@phil-livefront](https://github.com/phil-livefront) **Created:** 12/3/2024 **Status:** ✅ Merged **Merged:** 12/3/2024 **Merged by:** [@phil-livefront](https://github.com/phil-livefront) **Base:** `main` ← **Head:** `phil/PM-15147-Design-Audit-Master-Password-Guidance-Screen-Cleanup` --- ### 📝 Commits (2) - [`cc925c3`](https://github.com/bitwarden/android/commit/cc925c36a26af2afd3ff3b49baca1a7ce6124335) PR comments (remember view model and fix param order) - [`f0cf5f0`](https://github.com/bitwarden/android/commit/f0cf5f085d5c0f42cc655e45fc7bc65b59095378) Merge branch 'main' into phil/PM-15147-Design-Audit-Master-Password-Guidance-Screen-Cleanup ### 📊 Changes **1 file changed** (+8 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt` (+8 -6) </details> ### 📄 Description ## 🎟️ Tracking [PM-15147](https://bitwarden.atlassian.net/browse/PM-15147) ## 📔 Objective - Address PR comments from previous [PR](https://github.com/bitwarden/android/pull/4383) - Remembering viewModel to prevent unnecessary recompositions and fix order of function parameters ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-15147]: https://bitwarden.atlassian.net/browse/PM-15147?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:55:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#17681
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?