[PR #3426] BIT-2437: Add mitigation logic for bad encryption key #4215

New Issue

2025-11-26T23:41:41-06:00

GiteaMirror commented

2025-11-26 23:41:41 -06:00

Original Pull Request: https://github.com/bitwarden/android/pull/3426

State: closed
Merged: Yes

🎟️ Tracking

BIT-2437

📔 Objective

This PR attempt to mitigate a crash that occurs when trying to instantiate encrypted shared preferences.

This problem cannot be reproduced easily but has been tracked here.
The logic in this PR mitigates the issue but does not solve it.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

**Original Pull Request:** https://github.com/bitwarden/android/pull/3426 **State:** closed **Merged:** Yes --- ## 🎟️ Tracking [BIT-2437](https://livefront.atlassian.net/browse/BIT-2437) ## 📔 Objective This PR attempt to mitigate a crash that occurs when trying to instantiate encrypted shared preferences. This problem cannot be reproduced easily but has been tracked [here](https://issuetracker.google.com/issues/176215143). The logic in this PR _mitigates_ the issue but does not _solve_ it. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes

GiteaMirror added the pull-request label 2025-11-26 23:41:41 -06:00

GiteaMirror closed this issue