github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #4244] [CLOSED] PM-14411: accessibility autofill background #24175

New Issue
Closed
opened 2026-04-17 00:04:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 00:04:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4244
Author: @david-livefront
Created: 11/6/2024
Status: ❌ Closed

Base: main ← Head: PM-14411-accessibility-autofill-background

📝 Commits (7)

  • d71389a [PM-14241] Checking if Timber tree has been added before trying to remove it (#4194)
  • 42671aa [PM-14224] Automate Play Store prod variant publishing (#4183)
  • 75fc9fe [PM-14254] Keep Android verifier for JNI usage (#4197)
  • 9f8d21c PM-14255: Remove accessibility logic to improve overall performance (#4206)
  • 5523d99 [PM-14346] Run alias generation on the IO dispatcher (#4215)
  • 5a4b8d6 PM-14433 update flow type to nullable so we can handle gracefully and avoid crash. (#4231)
  • edfb396 PM-14411: Allow accessibility autofill to run when app is already in background

📊 Changes

11 files changed (+29 additions, -8 deletions)

View changed files

📝 .github/workflows/build.yml (+3 -1)
📝 app/proguard-rules.pro (+4 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/accessibility/BitwardenAccessibilityService.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/autofill/util/AutofillIntentUtils.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/tiles/BitwardenAutofillTileService.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/GeneratorRepositoryImpl.kt (+3 -1)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceImpl.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/dao/DomainsDao.kt (+1 -1)
📝 app/src/main/res/xml/accessibility_service.xml (+1 -1)
📝 app/src/standard/java/com/x8bit/bitwarden/data/platform/manager/LogsManagerImpl.kt (+1 -1)
📝 fastlane/Fastfile (+11 -0)

📄 Description

🎟️ Tracking

PM-14411

📔 Objective

This PR allows the accessibility autofill functionality to work when the app is already open.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4244 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 11/6/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `PM-14411-accessibility-autofill-background` --- ### 📝 Commits (7) - [`d71389a`](https://github.com/bitwarden/android/commit/d71389ab020c33b4ab4e50c2cb4b8c55edbe26f1) [PM-14241] Checking if Timber tree has been added before trying to remove it (#4194) - [`42671aa`](https://github.com/bitwarden/android/commit/42671aadfb84bccbce9613fdfa220c145fa9ed31) [PM-14224] Automate Play Store prod variant publishing (#4183) - [`75fc9fe`](https://github.com/bitwarden/android/commit/75fc9fe21040733008104ab7b9afe96ba0bc3121) [PM-14254] Keep Android verifier for JNI usage (#4197) - [`9f8d21c`](https://github.com/bitwarden/android/commit/9f8d21cb9587d1efc0ced2decf7df9b1bda37e5b) PM-14255: Remove accessibility logic to improve overall performance (#4206) - [`5523d99`](https://github.com/bitwarden/android/commit/5523d994004a226746164e61097043622f9b17b7) [PM-14346] Run alias generation on the IO dispatcher (#4215) - [`5a4b8d6`](https://github.com/bitwarden/android/commit/5a4b8d64abcd928c392930f2cd706c0c0b26db76) PM-14433 update flow type to nullable so we can handle gracefully and avoid crash. (#4231) - [`edfb396`](https://github.com/bitwarden/android/commit/edfb3966bbe8b13d52fb9999b8cd91659eddf874) PM-14411: Allow accessibility autofill to run when app is already in background ### 📊 Changes **11 files changed** (+29 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+3 -1) 📝 `app/proguard-rules.pro` (+4 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/accessibility/BitwardenAccessibilityService.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/autofill/util/AutofillIntentUtils.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/tiles/BitwardenAutofillTileService.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/GeneratorRepositoryImpl.kt` (+3 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceImpl.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/dao/DomainsDao.kt` (+1 -1) 📝 `app/src/main/res/xml/accessibility_service.xml` (+1 -1) 📝 `app/src/standard/java/com/x8bit/bitwarden/data/platform/manager/LogsManagerImpl.kt` (+1 -1) 📝 `fastlane/Fastfile` (+11 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-14411](https://bitwarden.atlassian.net/browse/PM-14411) ## 📔 Objective This PR allows the accessibility autofill functionality to work when the app is already open. ## 📸 Screenshots | Before | After | | --- | --- | | <video src="" width="300" /> | <video src="" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-14411]: https://bitwarden.atlassian.net/browse/PM-14411?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 00:04:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#24175
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?