github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3336] [CLOSED] Pm 6701/email verification selfhost registration #41240

New Issue
Closed
opened 2026-04-23 20:02:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 20:02:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3336
Author: @vvolkgang
Created: 6/21/2024
Status: ❌ Closed

Base: main ← Head: pm-6701/email-verification-selfhost-registration

📝 Commits (10+)

  • 45d0ac9 Apply result extension consistently (#1210)
  • 5b55ab6 Upon trusting device, update decryption options (#1211)
  • 6dc4cdd Update KSP (#1212)
  • 2df9aa1 Remove inline keyword from updatePasswordLength() (#1213)
  • a56300f Update Renovate config (#1215)
  • 8f0b42a Remove redundant call to set vault to unlocked (#1217)
  • 58c195a default timeout action should be LOGOUT when using TDE (#1216)
  • c6f0af5 Fix incorrect VM state access & unnecessary eventFlow usages (#1218)
  • 92fcf9d Fix minor dialog bug where top is not padded if title is missing (#1221)
  • c8727f2 Expose the 'shouldTrustDevice' boolean from auth repo (#1220)

📊 Changes

35 files changed (+2447 additions, -87 deletions)

View changed files

📝 app/src/main/AndroidManifest.xml (+11 -0)
📝 app/src/main/java/com/x8bit/bitwarden/MainActivity.kt (+10 -0)
📝 app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt (+11 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/auth/util/CompleteRegistrationDataUtils.kt (+19 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/CompleteRegistrationData.kt (+16 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/SpecialCircumstance.kt (+10 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/util/SpecialCircumstanceExtensions.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt (+29 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailNavigation.kt (+52 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailScreen.kt (+232 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailViewModel.kt (+93 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationNavigation.kt (+34 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt (+241 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt (+524 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/PasswordStrengthIndicator.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreen.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingNavigation.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt (+4 -79)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt (+10 -1)

...and 15 more files

📄 Description

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3336 **Author:** [@vvolkgang](https://github.com/vvolkgang) **Created:** 6/21/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `pm-6701/email-verification-selfhost-registration` --- ### 📝 Commits (10+) - [`45d0ac9`](https://github.com/bitwarden/android/commit/45d0ac98b88da699940768042d4def7c5ef67a44) Apply result extension consistently (#1210) - [`5b55ab6`](https://github.com/bitwarden/android/commit/5b55ab607071cd57ad8f429d594322b747e448e9) Upon trusting device, update decryption options (#1211) - [`6dc4cdd`](https://github.com/bitwarden/android/commit/6dc4cddfd63e1f00a01fa8c5cf2aff95bc758197) Update KSP (#1212) - [`2df9aa1`](https://github.com/bitwarden/android/commit/2df9aa1a0371ae66ac23412de3647c0be668e1a6) Remove inline keyword from updatePasswordLength() (#1213) - [`a56300f`](https://github.com/bitwarden/android/commit/a56300fe09db7aff718d468aa50d82d420b844ca) Update Renovate config (#1215) - [`8f0b42a`](https://github.com/bitwarden/android/commit/8f0b42a4415978ebe18e38f3cb11eafd7f00568d) Remove redundant call to set vault to unlocked (#1217) - [`58c195a`](https://github.com/bitwarden/android/commit/58c195a4df93d306b32ff266ac6ea9deb7d2714b) default timeout action should be LOGOUT when using TDE (#1216) - [`c6f0af5`](https://github.com/bitwarden/android/commit/c6f0af52bd81e87328dc80b51afa10a61a5bc500) Fix incorrect VM state access & unnecessary eventFlow usages (#1218) - [`92fcf9d`](https://github.com/bitwarden/android/commit/92fcf9dec8820c77a7bc5315e972239220b53f5b) Fix minor dialog bug where top is not padded if title is missing (#1221) - [`c8727f2`](https://github.com/bitwarden/android/commit/c8727f21fd0b956868d53314d6b9bb01251e40db) Expose the 'shouldTrustDevice' boolean from auth repo (#1220) ### 📊 Changes **35 files changed** (+2447 additions, -87 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/AndroidManifest.xml` (+11 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/MainActivity.kt` (+10 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt` (+11 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/auth/util/CompleteRegistrationDataUtils.kt` (+19 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/CompleteRegistrationData.kt` (+16 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/SpecialCircumstance.kt` (+10 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/util/SpecialCircumstanceExtensions.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt` (+29 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailNavigation.kt` (+52 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailScreen.kt` (+232 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailViewModel.kt` (+93 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationNavigation.kt` (+34 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt` (+241 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt` (+524 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/PasswordStrengthIndicator.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreen.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingNavigation.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreen.kt` (+4 -79) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt` (+10 -1) _...and 15 more files_ </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 20:02:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#41240
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?