github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 05:20:24 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2675] [MERGED] [PM-3362] Fix auth request approval #40816

New Issue
Closed
opened 2026-04-23 19:37:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 19:37:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2675
Author: @andrebispo5
Created: 8/10/2023
Status: ✅ Merged
Merged: 8/10/2023
Merged by: @andrebispo5

Base: feature/pm-1029-tde-login ← Head: auth/pm-3362-approverequest

📝 Commits (3)

  • 45116d9 [PM-3362] Fix auth request approval
  • 1133b07 [PM-3362] Add new exception type
  • 371eee1 [PM-3362] fix class rename

📊 Changes

4 files changed (+43 additions, -7 deletions)

View changed files

➕ src/Core/Exceptions/UserAndMasterKeyNullException.cs (+12 -0)
📝 src/Core/Models/Request/PasswordlessLoginRequest.cs (+1 -1)
📝 src/Core/Services/AuthService.cs (+23 -5)
📝 src/Core/Services/CryptoService.cs (+7 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

If the approval device had login without a password, it wouldn't be able to respond to auth requests.

Code changes

There was some code missing for the auth requests response when the user didn't have a Master Password set.

Screenshots

https://github.com/bitwarden/mobile/assets/4648522/24353027-a147-4be0-a005-462d3a914151

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2675 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 8/10/2023 **Status:** ✅ Merged **Merged:** 8/10/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `feature/pm-1029-tde-login` ← **Head:** `auth/pm-3362-approverequest` --- ### 📝 Commits (3) - [`45116d9`](https://github.com/bitwarden/android/commit/45116d91907ddb6639e3636821c9c72d408d5c60) [PM-3362] Fix auth request approval - [`1133b07`](https://github.com/bitwarden/android/commit/1133b07df3421d4a53d664def47b83e0759d1512) [PM-3362] Add new exception type - [`371eee1`](https://github.com/bitwarden/android/commit/371eee111fb359ccbd38748ea546d563cd841853) [PM-3362] fix class rename ### 📊 Changes **4 files changed** (+43 additions, -7 deletions) <details> <summary>View changed files</summary> ➕ `src/Core/Exceptions/UserAndMasterKeyNullException.cs` (+12 -0) 📝 `src/Core/Models/Request/PasswordlessLoginRequest.cs` (+1 -1) 📝 `src/Core/Services/AuthService.cs` (+23 -5) 📝 `src/Core/Services/CryptoService.cs` (+7 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> If the approval device had login without a password, it wouldn't be able to respond to auth requests. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> There was some code missing for the auth requests response when the user didn't have a Master Password set. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> https://github.com/bitwarden/mobile/assets/4648522/24353027-a147-4be0-a005-462d3a914151 ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 19:37:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#40816
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?