github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #943] [MERGED] Don't build the keyboard index for autofill if using logout action #2675

New Issue
Closed
opened 2025-11-26 23:22:32 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:32 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/943
Author: @kspearrin
Created: 6/1/2020
Status: ✅ Merged
Merged: 6/1/2020
Merged by: @kspearrin

Base: master ← Head: noautofillindex

📝 Commits (2)

  • b17df65 Don't build the keyboard index for autofill if using logout action
  • 23405d4 trigger index rebuild on vault timeout changed event

📊 Changes

3 files changed (+44 additions, -8 deletions)

View changed files

📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+19 -7)
📝 src/iOS.Core/Utilities/ASHelpers.cs (+11 -0)
📝 src/iOS/AppDelegate.cs (+14 -1)

📄 Description

If users are using the vault timeout feature to log out of the app, the autofill index may not be cleared when they are logged out (ex, the app just terminates). This is because the traditional loggedout message event may never occur. I would consider this a security issue since it would lead to a logged out user still receiving hints in their keyboard about items that were in their vault. If a user is using the vault timeout == "logOut" feature, we cannot maintain the autofill index for keyboard hints.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/943 **Author:** [@kspearrin](https://github.com/kspearrin) **Created:** 6/1/2020 **Status:** ✅ Merged **Merged:** 6/1/2020 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `noautofillindex` --- ### 📝 Commits (2) - [`b17df65`](https://github.com/bitwarden/android/commit/b17df65f92cf347907ea2a6c1aff8178f1244a8b) Don't build the keyboard index for autofill if using logout action - [`23405d4`](https://github.com/bitwarden/android/commit/23405d409dbd6811053d364266a8b21ecfb5bfcc) trigger index rebuild on vault timeout changed event ### 📊 Changes **3 files changed** (+44 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+19 -7) 📝 `src/iOS.Core/Utilities/ASHelpers.cs` (+11 -0) 📝 `src/iOS/AppDelegate.cs` (+14 -1) </details> ### 📄 Description If users are using the vault timeout feature to log out of the app, the autofill index may not be cleared when they are logged out (ex, the app just terminates). This is because the traditional loggedout message event may never occur. I would consider this a security issue since it would lead to a logged out user still receiving hints in their keyboard about items that were in their vault. If a user is using the vault timeout == "logOut" feature, we cannot maintain the autofill index for keyboard hints. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:32 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2675
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?