github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2604] [MERGED] [AC-1425] Fix iOS blank vault load #40763

New Issue
Closed
opened 2026-04-23 19:35:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 19:35:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2604
Author: @fedemkr
Created: 7/7/2023
Status: ✅ Merged
Merged: 7/17/2023
Merged by: @fedemkr

Base: master ← Head: vault/ac-1425-fix-ios-pull-to-refresh

📝 Commits (2)

  • 960b50c ac-1425 added main thread invocations when updating the vault properties to fix cases where the screen stays blank and doesn't update
  • e9bfeb2 Merge branch 'master' into vault/ac-1425-fix-ios-pull-to-refresh

📊 Changes

1 file changed (+29 additions, -20 deletions)

View changed files

📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs (+29 -20)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR attempts to fix an issue happening from time to time, where the vault view's list doesn't load
Even though I couldn't reproduce the issue, I forced in the code the properties not to propagate changes to the view which end in this state, and based on these assumptions this fix is presented.

Code changes

  • GroupingPageViewModel: Added a bunch of main thread invocations for the properties expected to change from the view, so in case there is another thread executing the load, the property changed will be invoked in the main thread.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2604 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 7/7/2023 **Status:** ✅ Merged **Merged:** 7/17/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `vault/ac-1425-fix-ios-pull-to-refresh` --- ### 📝 Commits (2) - [`960b50c`](https://github.com/bitwarden/android/commit/960b50c4fccb174514c9854bea1115fca9654436) ac-1425 added main thread invocations when updating the vault properties to fix cases where the screen stays blank and doesn't update - [`e9bfeb2`](https://github.com/bitwarden/android/commit/e9bfeb2a9e8463ebd1544386acdd0ffd4c20bd7c) Merge branch 'master' into vault/ac-1425-fix-ios-pull-to-refresh ### 📊 Changes **1 file changed** (+29 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs` (+29 -20) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> This PR attempts to fix an issue happening from time to time, where the vault view's list doesn't load Even though I couldn't reproduce the issue, I forced in the code the properties not to propagate changes to the view which end in this state, and based on these assumptions this fix is presented. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **GroupingPageViewModel:** Added a bunch of main thread invocations for the properties expected to change from the view, so in case there is another thread executing the load, the property changed will be invoked in the main thread. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 19:35:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#40763
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?