github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #831] [MERGED] [Auto-Logout] Lock Service name refactor #2604

New Issue
Closed
opened 2025-11-26 23:21:36 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:21:36 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/831
Author: @vincentsalucci
Created: 4/13/2020
Status: ✅ Merged
Merged: 4/13/2020
Merged by: @vincentsalucci

Base: feature-auto-logout ← Head: fal-lock-option-refactor

📝 Commits (1)

  • 010edc8 Initial commit of LockService name refactor

📊 Changes

16 files changed (+68 additions, -68 deletions)

View changed files

📝 src/Android/Autofill/AutofillService.cs (+4 -4)
📝 src/Android/Receivers/LockAlarmReceiver.cs (+2 -2)
📝 src/App/App.xaml.cs (+9 -9)
📝 src/App/Pages/Accounts/LockPageViewModel.cs (+9 -9)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+9 -9)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs (+3 -3)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs (+3 -3)
📝 src/Core/Abstractions/IVaultTimeoutService.cs (+1 -1)
📝 src/Core/Services/AuthService.cs (+4 -4)
📝 src/Core/Services/VaultTimeoutService.cs (+2 -2)
📝 src/Core/Utilities/ServiceContainer.cs (+4 -4)
📝 src/iOS.Autofill/CredentialProviderViewController.cs (+2 -2)
📝 src/iOS.Core/Controllers/LockPasswordViewController.cs (+9 -9)
📝 src/iOS.Core/Utilities/ASHelpers.cs (+2 -2)
📝 src/iOS.Extension/LoadingViewController.cs (+2 -2)
📝 src/iOS/AppDelegate.cs (+3 -3)

📄 Description

Objective

Begin name refactor of LockService to VaultTimeoutService. No logic changes are present.

CodeChanges

  • Variable name refactor from lockService to vaultTimeoutService.
  • Updated interface reference from ILockService to IVaultTimeoutService.
  • Updated service calls to use name refactor.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/831 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 4/13/2020 **Status:** ✅ Merged **Merged:** 4/13/2020 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `feature-auto-logout` ← **Head:** `fal-lock-option-refactor` --- ### 📝 Commits (1) - [`010edc8`](https://github.com/bitwarden/android/commit/010edc8dc69b2397fe19ac136aa19a1f2e7b6c35) Initial commit of LockService name refactor ### 📊 Changes **16 files changed** (+68 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Autofill/AutofillService.cs` (+4 -4) 📝 `src/Android/Receivers/LockAlarmReceiver.cs` (+2 -2) 📝 `src/App/App.xaml.cs` (+9 -9) 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+9 -9) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+9 -9) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs` (+3 -3) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs` (+3 -3) 📝 `src/Core/Abstractions/IVaultTimeoutService.cs` (+1 -1) 📝 `src/Core/Services/AuthService.cs` (+4 -4) 📝 `src/Core/Services/VaultTimeoutService.cs` (+2 -2) 📝 `src/Core/Utilities/ServiceContainer.cs` (+4 -4) 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+2 -2) 📝 `src/iOS.Core/Controllers/LockPasswordViewController.cs` (+9 -9) 📝 `src/iOS.Core/Utilities/ASHelpers.cs` (+2 -2) 📝 `src/iOS.Extension/LoadingViewController.cs` (+2 -2) 📝 `src/iOS/AppDelegate.cs` (+3 -3) </details> ### 📄 Description ## Objective > Begin name refactor of `LockService` to `VaultTimeoutService`. No logic changes are present. ## CodeChanges - Variable name refactor from `lockService` to `vaultTimeoutService`. - Updated interface reference from `ILockService` to `IVaultTimeoutService`. - Updated service calls to use name refactor. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:36 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2604
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?