github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2653] [PM-3102] Update Master password reprompt to be based on MP instead of Key Connector #3707

New Issue
Closed
opened 2025-11-26 23:36:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:36:21 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/2653

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Update master password reprompt to be based on HasMasterPassword from the decrypt options instead of the Key connector. However, still use key connector as a default in case it's an old state.

Based on client's change 87468a2aa6

Code changes

  • UserVerificationService: Added HasMasterPasswordAsync() to check whether the user has a MP set up defaulting to check the key connector.
  • PasswordRepromptService: Removed Enabled() given that it's not being used.
  • Others: Updated all the references to IKeyConnectorService.GetUsesKeyConnector() to the new check on the IUserVerificationService, inverting the bool check given that it's the opposite now.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/2653 **State:** closed **Merged:** Yes --- ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Update master password reprompt to be based on `HasMasterPassword` from the decrypt options instead of the Key connector. However, still use key connector as a default in case it's an old state. Based on client's change https://github.com/bitwarden/clients/commit/87468a2aa65f500d5f2a24637296da91c1aa65ee ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **UserVerificationService:** Added `HasMasterPasswordAsync()` to check whether the user has a MP set up defaulting to check the key connector. * **PasswordRepromptService:** Removed `Enabled()` given that it's not being used. * **Others:** Updated all the references to `IKeyConnectorService.GetUsesKeyConnector()` to the new check on the `IUserVerificationService`, inverting the bool check given that it's the opposite now. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:36:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3707
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?