github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #910] [MERGED] lock screen drawing & 2FA entry bugfixes #2653

New Issue
Closed
opened 2025-11-26 23:22:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/910
Author: @mpbw2
Created: 5/19/2020
Status: ✅ Merged
Merged: 5/20/2020
Merged by: @mpbw2

Base: master ← Head: bugfixes

📝 Commits (2)

  • 8f6e896 lock screen drawing & 2FA entry bugfixes
  • 25be77d cleanup whitespace

📊 Changes

2 files changed (+10 additions, -17 deletions)

View changed files

📝 src/App/App.xaml.cs (+0 -7)
📝 src/App/Pages/Accounts/TwoFactorPage.xaml.cs (+10 -10)

📄 Description

TwoFactorPage.xaml.cs - The focus request would only ever happen once since it was behind the !_inited condition. Changed this to always perform the focus request in OnAppearing() while only restricting _vm.Init() to the !_inited condition. Fixes #905

App.xaml.cs - removed the workaround added mid-December. The Xamarin.Forms issue linked was closed on Feb 11, and the Forms updates since then were no longer reacting well to the workaround, resulting in what appeared to be an empty instance of the lockPage instead of the one already available. Fixes #906

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/910 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 5/19/2020 **Status:** ✅ Merged **Merged:** 5/20/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfixes` --- ### 📝 Commits (2) - [`8f6e896`](https://github.com/bitwarden/android/commit/8f6e8965c89acc4373a7e3551db9ebdda7688f41) lock screen drawing & 2FA entry bugfixes - [`25be77d`](https://github.com/bitwarden/android/commit/25be77dcead7fe2d3772bd7d8f2f11cf65da2756) cleanup whitespace ### 📊 Changes **2 files changed** (+10 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.xaml.cs` (+0 -7) 📝 `src/App/Pages/Accounts/TwoFactorPage.xaml.cs` (+10 -10) </details> ### 📄 Description **TwoFactorPage.xaml.cs** - The focus request would only ever happen once since it was behind the `!_inited` condition. Changed this to always perform the focus request in `OnAppearing()` while only restricting `_vm.Init()` to the `!_inited` condition. Fixes #905 **App.xaml.cs** - removed the workaround added mid-December. The Xamarin.Forms issue linked was closed on Feb 11, and the Forms updates since then were no longer reacting well to the workaround, resulting in what appeared to be an empty instance of the lockPage instead of the one already available. Fixes #906 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2653
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?