github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 93 Wiki Activity

[PR #2575] [MERGED] [PM-2611] Adding IDs for Cipher/Send search results #3655

New Issue
Closed
opened 2025-11-26 23:35:46 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:35:46 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2575
Author: @ifernandezdiaz
Created: 6/19/2023
Status: ✅ Merged
Merged: 6/20/2023
Merged by: @ifernandezdiaz

Base: master ← Head: PM-2611/add-automationids-search-pages

📝 Commits (2)

  • 42e7cac Adding IDs for Cipher/Send search results
  • 39f6a0b Adding missing spaces

📊 Changes

4 files changed (+43 additions, -22 deletions)

View changed files

📝 src/App/Controls/CipherViewCell/CipherViewCell.xaml (+16 -8)
📝 src/App/Controls/SendViewCell/SendViewCell.xaml (+17 -9)
📝 src/App/Pages/Send/SendsPage.xaml (+4 -2)
📝 src/App/Pages/Vault/CiphersPage.xaml (+6 -3)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests

Code changes

  • CipherViewCell.xaml: Adding locators for Cipher cell elements
  • SendViewCell.xaml: Adding locators for Send cell elements
  • CiphersPage.xaml: Adding locators for cipher list, empty list label and Search bar
  • SendsPage.xaml: Adding ids for each send cell

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2575 **Author:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Created:** 6/19/2023 **Status:** ✅ Merged **Merged:** 6/20/2023 **Merged by:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Base:** `master` ← **Head:** `PM-2611/add-automationids-search-pages` --- ### 📝 Commits (2) - [`42e7cac`](https://github.com/bitwarden/android/commit/42e7cac8ecc36861527221470f96ffdbf8f5e09a) Adding IDs for Cipher/Send search results - [`39f6a0b`](https://github.com/bitwarden/android/commit/39f6a0b9d3f801350d01175d3eeb5edccdecb3d2) Adding missing spaces ### 📊 Changes **4 files changed** (+43 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/CipherViewCell/CipherViewCell.xaml` (+16 -8) 📝 `src/App/Controls/SendViewCell/SendViewCell.xaml` (+17 -9) 📝 `src/App/Pages/Send/SendsPage.xaml` (+4 -2) 📝 `src/App/Pages/Vault/CiphersPage.xaml` (+6 -3) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests ## Code changes * **CipherViewCell.xaml:** Adding locators for Cipher cell elements * **SendViewCell.xaml:** Adding locators for Send cell elements * **CiphersPage.xaml:** Adding locators for cipher list, empty list label and Search bar * **SendsPage.xaml:** Adding ids for each send cell ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:35:46 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3655
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?