github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #757] [MERGED] Wait for app to resume before attempting to set Application.Current.MainPage #2575

New Issue
Closed
opened 2025-11-26 23:21:13 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:21:13 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/757
Author: @mpbw2
Created: 3/5/2020
Status: ✅ Merged
Merged: 3/5/2020
Merged by: @mpbw2

Base: master ← Head: bugfix-duo

📝 Commits (1)

  • 55683dd Workaround for older bug in Xamarin.Forms by waiting for app to resume before attempting to set Application.Current.MainPage

📊 Changes

2 files changed (+26 additions, -0 deletions)

View changed files

📝 src/App/App.xaml.cs (+25 -0)
📝 src/App/Pages/Accounts/TwoFactorPageViewModel.cs (+1 -0)

📄 Description

Workaround for older bug in Xamarin.Forms by waiting for app to resume before attempting to set Application.Current.MainPage. Fixed in latest Xamarin.Forms 4.4.0.x but it's too dangerous to swap that out so close to a release.

This fixes the issue with Duo that only occurs when you leave the Bitwarden app completely to acknowledge the push (in recent versions of Android you can ack the push directly from the Duo notification, never leaving the Bitwarden app)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/757 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 3/5/2020 **Status:** ✅ Merged **Merged:** 3/5/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-duo` --- ### 📝 Commits (1) - [`55683dd`](https://github.com/bitwarden/android/commit/55683ddea49deb645b0ddb77e7f8ebe3475c60ed) Workaround for older bug in Xamarin.Forms by waiting for app to resume before attempting to set Application.Current.MainPage ### 📊 Changes **2 files changed** (+26 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.xaml.cs` (+25 -0) 📝 `src/App/Pages/Accounts/TwoFactorPageViewModel.cs` (+1 -0) </details> ### 📄 Description Workaround for older bug in Xamarin.Forms by waiting for app to resume before attempting to set Application.Current.MainPage. Fixed in latest Xamarin.Forms 4.4.0.x but it's too dangerous to swap that out so close to a release. This fixes the issue with Duo that only occurs when you leave the Bitwarden app completely to acknowledge the push (in recent versions of Android you can ack the push directly from the Duo notification, never leaving the Bitwarden app) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:13 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2575
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?