github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-17 18:43:11 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2569] [MERGED] Adding AutomationIDs on Generator page elements #3650

New Issue
Closed
opened 2025-11-26 23:35:42 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:35:42 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2569
Author: @ifernandezdiaz
Created: 6/15/2023
Status: ✅ Merged
Merged: 6/15/2023
Merged by: @ifernandezdiaz

Base: master ← Head: PM-2610/add-automationIDs-for-generator-page-elements

📝 Commits (2)

  • d6fdb0c Adding AutomationIDs on Generator pages
  • 48908e6 Adding missing spaces

📊 Changes

2 files changed (+96 additions, -48 deletions)

View changed files

📝 src/App/Pages/Generator/GeneratorHistoryPage.xaml (+12 -6)
📝 src/App/Pages/Generator/GeneratorPage.xaml (+84 -42)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests

Code changes

  • GeneratorPage.xaml: Adding IDs for all the interactable elements displayed for passwords/usernames
  • GeneratorPageHistory.xaml: Adding IDs for each cell, apart from the locators for each nested element

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2569 **Author:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Created:** 6/15/2023 **Status:** ✅ Merged **Merged:** 6/15/2023 **Merged by:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Base:** `master` ← **Head:** `PM-2610/add-automationIDs-for-generator-page-elements` --- ### 📝 Commits (2) - [`d6fdb0c`](https://github.com/bitwarden/android/commit/d6fdb0c6a565fa47021bbee6415738bf27dac8e2) Adding AutomationIDs on Generator pages - [`48908e6`](https://github.com/bitwarden/android/commit/48908e68da224ff266739a825993854f41e35d2b) Adding missing spaces ### 📊 Changes **2 files changed** (+96 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Generator/GeneratorHistoryPage.xaml` (+12 -6) 📝 `src/App/Pages/Generator/GeneratorPage.xaml` (+84 -42) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective This PR adds more AutomationIDs that will help us to improve the quality of our Mobile Automation tests ## Code changes * **GeneratorPage.xaml:** Adding IDs for all the interactable elements displayed for passwords/usernames * **GeneratorPageHistory.xaml:** Adding IDs for each cell, apart from the locators for each nested element ## Screenshots ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:35:42 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3650
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?