github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-17 10:04:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #751] [MERGED] New Android attachment handling to support saving or opening attachments #2569

New Issue
Closed
opened 2025-11-26 23:21:09 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:21:09 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/751
Author: @mpbw2
Created: 3/2/2020
Status: ✅ Merged
Merged: 3/3/2020
Merged by: @mpbw2

Base: master ← Head: feature-saveattachment

📝 Commits (2)

  • b3dd27b New Android attachment handling to support saving or opening (when available) attachments
  • 66a843c Simplified options dialog logic & changed error text

📊 Changes

5 files changed (+126 additions, -15 deletions)

View changed files

📝 src/Android/Services/DeviceActionService.cs (+2 -9)
📝 src/App/Pages/Vault/ViewPage.xaml.cs (+14 -1)
📝 src/App/Pages/Vault/ViewPageViewModel.cs (+82 -5)
📝 src/App/Resources/AppResources.Designer.cs (+18 -0)
📝 src/App/Resources/AppResources.resx (+10 -0)

📄 Description

Introduced new attachment handling flow for Android: Click download icon -> perform download -> If the file can be opened by the system, present user with "open or save" prompt -> If the file can't be opened by the system, go directly into the save flow. This effectively means we can save any type of attachment + optionally open/view directly if supported.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/751 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 3/2/2020 **Status:** ✅ Merged **Merged:** 3/3/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `feature-saveattachment` --- ### 📝 Commits (2) - [`b3dd27b`](https://github.com/bitwarden/android/commit/b3dd27b611173eb9ba60fd483f549ee0d11c1220) New Android attachment handling to support saving or opening (when available) attachments - [`66a843c`](https://github.com/bitwarden/android/commit/66a843c4b045b521c66afeda3adee4b1f2a3eb5c) Simplified options dialog logic & changed error text ### 📊 Changes **5 files changed** (+126 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Services/DeviceActionService.cs` (+2 -9) 📝 `src/App/Pages/Vault/ViewPage.xaml.cs` (+14 -1) 📝 `src/App/Pages/Vault/ViewPageViewModel.cs` (+82 -5) 📝 `src/App/Resources/AppResources.Designer.cs` (+18 -0) 📝 `src/App/Resources/AppResources.resx` (+10 -0) </details> ### 📄 Description Introduced new attachment handling flow for Android: Click download icon -> perform download -> If the file can be opened by the system, present user with "open or save" prompt -> If the file can't be opened by the system, go directly into the save flow. This effectively means we can save any type of attachment + optionally open/view directly if supported. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:21:09 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2569
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?