github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-25 15:51:22 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #2507] [MERGED] [PM-1352] Fix Avatar toolbar icon on OTP cipher selection #3605

New Issue
Closed
opened 2025-11-26 23:35:05 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:35:05 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2507
Author: @fedemkr
Created: 5/5/2023
Status: ✅ Merged
Merged: 5/5/2023
Merged by: @fedemkr

Base: master ← Head: bug/PM-1352-fix-acc-switch-toolbar-icon-otp-flow

📝 Commits (2)

  • c6932b0 PM-1352 Fix avatar toolbar item not loading on OTP cipher selection
  • 2812e69 Merge branch 'master' into bug/PM-1352-fix-acc-switch-toolbar-icon-otp-flow

📊 Changes

2 files changed (+7 additions, -5 deletions)

View changed files

📝 src/App/Pages/Vault/CipherSelectionPage.xaml (+1 -1)
📝 src/App/Pages/Vault/CipherSelectionPage.xaml.cs (+6 -4)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

🐛 Fix the toolbar icon for the avatar switch on OTP cipher selection that wasn't being loaded.

Code changes

  • CipherSelectionPage.xaml: Changed toolbar item priority to "-1" which seems to fix the bug and not the icon loads and updates in the UI correctly
  • CipherSelectionPage.xaml.cs: Enabled back the account toolbar icon loading and surrounded it in a try...catch so that the app doesn't crash if the icon can't be loaded somehow.

Screenshots

OTP cipher selection account toolbar icon

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2507 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 5/5/2023 **Status:** ✅ Merged **Merged:** 5/5/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `bug/PM-1352-fix-acc-switch-toolbar-icon-otp-flow` --- ### 📝 Commits (2) - [`c6932b0`](https://github.com/bitwarden/android/commit/c6932b0f89cbc403636b378c88f1012dd0aa0dc8) PM-1352 Fix avatar toolbar item not loading on OTP cipher selection - [`2812e69`](https://github.com/bitwarden/android/commit/2812e69fa9ef94aa5960eab4e4a521952852704e) Merge branch 'master' into bug/PM-1352-fix-acc-switch-toolbar-icon-otp-flow ### 📊 Changes **2 files changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/CipherSelectionPage.xaml` (+1 -1) 📝 `src/App/Pages/Vault/CipherSelectionPage.xaml.cs` (+6 -4) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> 🐛 Fix the toolbar icon for the avatar switch on OTP cipher selection that wasn't being loaded. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CipherSelectionPage.xaml:** Changed toolbar item priority to "-1" which seems to fix the bug and not the icon loads and updates in the UI correctly * **CipherSelectionPage.xaml.cs:** Enabled back the account toolbar icon loading and surrounded it in a try...catch so that the app doesn't crash if the icon can't be loaded somehow. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> <img width="314" alt="OTP cipher selection account toolbar icon" src="https://user-images.githubusercontent.com/15682323/236491502-a591a45b-f293-4a2b-87db-e966a13df05a.jpeg"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:35:05 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3605
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?