github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-25 15:51:22 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #449] [MERGED] Handle exception when adding attachment that does not exist on file system. #2507

New Issue
Closed
opened 2025-11-26 23:20:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:20:20 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/449
Author: @devsecdan
Created: 1/22/2019
Status: ✅ Merged
Merged: 1/22/2019
Merged by: @kspearrin

Base: master ← Head: master

📝 Commits (1)

  • 3a27d0c Handle exception when adding attachment that does not exist on file system.

📊 Changes

1 file changed (+12 additions, -5 deletions)

View changed files

📝 src/Android/MainActivity.cs (+12 -5)

📄 Description

Bitwarden crashes when trying to add a file that does not exist on the filesystem as an attachment.

The Android 'Documents' app seems to keep a cache of downloaded files despite those files having been deleted off of the file system. This causes Bitwarden to crash when the user selects them.

I figure that presenting some error to the user when this happens makes sense, but beyond the generic "An error has occurred" message, I couldn't find a suitable resource.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/449 **Author:** [@devsecdan](https://github.com/devsecdan) **Created:** 1/22/2019 **Status:** ✅ Merged **Merged:** 1/22/2019 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`3a27d0c`](https://github.com/bitwarden/android/commit/3a27d0c01d2068c99c0e0b65e339fba9c716bc5b) Handle exception when adding attachment that does not exist on file system. ### 📊 Changes **1 file changed** (+12 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainActivity.cs` (+12 -5) </details> ### 📄 Description Bitwarden crashes when trying to add a file that does not exist on the filesystem as an attachment. The Android 'Documents' app seems to keep a cache of downloaded files despite those files having been deleted off of the file system. This causes Bitwarden to crash when the user selects them. I figure that presenting some error to the user when this happens makes sense, but beyond the generic "An error has occurred" message, I couldn't find a suitable resource. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:20:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2507
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?