github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #2450] [CLOSED] [PM-1627] Add android autofill support for org.chromium.chrome.stable #3570

New Issue
Closed
opened 2025-11-26 23:34:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:34:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2450
Author: @nielscil
Created: 3/27/2023
Status: ❌ Closed

Base: main ← Head: features/add-chromium-chrome-stable

📝 Commits (5)

  • a6e1118 Add android autofill support for org.chromium.chrome.stable
  • 74d7b4f Merge branch 'master' into features/add-chromium-chrome-stable
  • 8972a0d Merge branch 'master' into features/add-chromium-chrome-stable
  • a9e7a16 Merge branch 'master' into features/add-chromium-chrome-stable
  • ce765de Merge branch 'master' into features/add-chromium-chrome-stable

📊 Changes

3 files changed (+5 additions, -0 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+1 -0)
📝 src/Android/Autofill/AutofillHelpers.cs (+1 -0)
📝 src/Android/Resources/xml/autofillservice.xml (+3 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Autofill wasn't working for macchrome's Chromium. With this PR I've added the package name to the autofill and accessibilityhelper to fix this issue.

Code changes

  • src/Android/Accessibility/AccessibilityHelpers.cs: Added Browser object with package name
  • src/Android/Autofill/AutofillHelpers.cs: Added package name
  • src/Android/Resources/xml/autofillservice.xml: Added package

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2450 **Author:** [@nielscil](https://github.com/nielscil) **Created:** 3/27/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `features/add-chromium-chrome-stable` --- ### 📝 Commits (5) - [`a6e1118`](https://github.com/bitwarden/android/commit/a6e111817467bff17f32c134a0904e88c070121e) Add android autofill support for org.chromium.chrome.stable - [`74d7b4f`](https://github.com/bitwarden/android/commit/74d7b4f69cbf3c91d5aa0f9adf66ea85050eaafa) Merge branch 'master' into features/add-chromium-chrome-stable - [`8972a0d`](https://github.com/bitwarden/android/commit/8972a0dfa4b5cc694ba0601f56fc0668f048516e) Merge branch 'master' into features/add-chromium-chrome-stable - [`a9e7a16`](https://github.com/bitwarden/android/commit/a9e7a16f3204760d1220eb55336a6186647be18b) Merge branch 'master' into features/add-chromium-chrome-stable - [`ce765de`](https://github.com/bitwarden/android/commit/ce765de95890cea959f1b2c953f01e201f27d35e) Merge branch 'master' into features/add-chromium-chrome-stable ### 📊 Changes **3 files changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+1 -0) 📝 `src/Android/Autofill/AutofillHelpers.cs` (+1 -0) 📝 `src/Android/Resources/xml/autofillservice.xml` (+3 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [x] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Autofill wasn't working for macchrome's [Chromium](https://github.com/macchrome/droidchrome). With this PR I've added the package name to the autofill and accessibilityhelper to fix this issue. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/Android/Accessibility/AccessibilityHelpers.cs:** Added Browser object with package name * **src/Android/Autofill/AutofillHelpers.cs:** Added package name * **src/Android/Resources/xml/autofillservice.xml:** Added package ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3570
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?