github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #199] [MERGED] Improve the navigation on Windows platforms #2450

New Issue
Closed
opened 2025-11-26 23:19:36 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:19:36 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/199
Author: @alistair23
Created: 12/7/2017
Status: ✅ Merged
Merged: 12/12/2017
Merged by: @kspearrin

Base: master ← Head: alistair/modal

📝 Commits (5)

  • 7e1417c App: Don't default to modal pushes on Windows
  • c0aa77a App: LoginPage.cs: Don't add the cancel button on Windows
  • 2b10d06 src: Set a icon for UWP cancel buttons
  • 7a8e88c App: Pages: Don't add Cancel/Close button on Windows
  • 6902f1a Update DismissModalToolBarItem.cs

📊 Changes

15 files changed (+28 additions, -14 deletions)

View changed files

📝 src/App/Controls/DismissModalToolBarItem.cs (+3 -1)
📝 src/App/Pages/EnvironmentPage.cs (+1 -1)
📝 src/App/Pages/LoginPage.cs (+1 -1)
📝 src/App/Pages/RegisterPage.cs (+1 -1)
📝 src/App/Pages/ScanPage.cs (+1 -1)
📝 src/App/Pages/Tools/ToolsExtensionPage.cs (+1 -1)
📝 src/App/Pages/Tools/ToolsPasswordGeneratorPage.cs (+1 -1)
📝 src/App/Pages/Vault/VaultAddCipherPage.cs (+1 -1)
📝 src/App/Pages/Vault/VaultAttachmentsPage.cs (+1 -1)
📝 src/App/Pages/Vault/VaultCustomFieldsPage.cs (+2 -2)
📝 src/App/Pages/Vault/VaultEditCipherPage.cs (+1 -1)
📝 src/App/Pages/Vault/VaultViewCipherPage.cs (+1 -1)
📝 src/App/Utilities/Extentions.cs (+12 -1)
📝 src/UWP.Images/UWP.Images.projitems (+1 -0)
➕ src/UWP.Images/ion_chevron_left.png (+0 -0)

📄 Description

Modal pages don't get back arrows on Windows desktop apps. To match the usual UWP style remove most of the cancel buttons and mark a large number of pages as non-modal to get a back button.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/199 **Author:** [@alistair23](https://github.com/alistair23) **Created:** 12/7/2017 **Status:** ✅ Merged **Merged:** 12/12/2017 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `alistair/modal` --- ### 📝 Commits (5) - [`7e1417c`](https://github.com/bitwarden/android/commit/7e1417c4804c150429b1b311bb63bef69a2b2bab) App: Don't default to modal pushes on Windows - [`c0aa77a`](https://github.com/bitwarden/android/commit/c0aa77a28fa130e880d29b848eff790329f0b9d7) App: LoginPage.cs: Don't add the cancel button on Windows - [`2b10d06`](https://github.com/bitwarden/android/commit/2b10d06ced98d5f279c7d3b4e1e796e5c45537c6) src: Set a icon for UWP cancel buttons - [`7a8e88c`](https://github.com/bitwarden/android/commit/7a8e88c4937f3d90a20e3a820c0494dc7eed1021) App: Pages: Don't add Cancel/Close button on Windows - [`6902f1a`](https://github.com/bitwarden/android/commit/6902f1a0da3740563a3cf3e5d101cc0c1dc1bd34) Update DismissModalToolBarItem.cs ### 📊 Changes **15 files changed** (+28 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/DismissModalToolBarItem.cs` (+3 -1) 📝 `src/App/Pages/EnvironmentPage.cs` (+1 -1) 📝 `src/App/Pages/LoginPage.cs` (+1 -1) 📝 `src/App/Pages/RegisterPage.cs` (+1 -1) 📝 `src/App/Pages/ScanPage.cs` (+1 -1) 📝 `src/App/Pages/Tools/ToolsExtensionPage.cs` (+1 -1) 📝 `src/App/Pages/Tools/ToolsPasswordGeneratorPage.cs` (+1 -1) 📝 `src/App/Pages/Vault/VaultAddCipherPage.cs` (+1 -1) 📝 `src/App/Pages/Vault/VaultAttachmentsPage.cs` (+1 -1) 📝 `src/App/Pages/Vault/VaultCustomFieldsPage.cs` (+2 -2) 📝 `src/App/Pages/Vault/VaultEditCipherPage.cs` (+1 -1) 📝 `src/App/Pages/Vault/VaultViewCipherPage.cs` (+1 -1) 📝 `src/App/Utilities/Extentions.cs` (+12 -1) 📝 `src/UWP.Images/UWP.Images.projitems` (+1 -0) ➕ `src/UWP.Images/ion_chevron_left.png` (+0 -0) </details> ### 📄 Description Modal pages don't get back arrows on Windows desktop apps. To match the usual UWP style remove most of the cancel buttons and mark a large number of pages as non-modal to get a back button. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:19:36 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2450
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?