github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-10 04:03:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2401] [CLOSED] Ask for password reprompt (if enabled) in chipers page #3543

New Issue
Closed
opened 2025-11-26 23:34:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:34:11 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2401
Author: @Marplex
Created: 3/5/2023
Status: ❌ Closed

Base: main ← Head: fix-ask-reprompt-autofill

📝 Commits (10+)

  • 48a8d9a Clipboard handling adjustments for Android 13 (#1947)
  • 388ad4e lib updates (#1949)
  • 51a5f58 Fixed vault filter display issue with personal ownership policy (#1950)
  • 5579817 Updating the release version check to use the new action (#1934)
  • f9cbe43 [PIQ-3] Add Github Actions to help manage issues and PRs (#1948)
  • e51233b Update README and CONTRIBUTING to use contributing.bitwarden.com (#1932)
  • 448758a Additional logic around filter display (#1951)
  • c53a85c [SG-390] Fix for missing org items with single org & personal ownership enabled (#1953)
  • 3aef86b [SG-386] iOS Update user state when coming from background (#1952)
  • f24388c separate init and showVaultFilter property set (#1954)

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 src/App/Pages/Vault/CiphersPageViewModel.cs (+6 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR fixes the issue #1866. Now the app is asking for password reprompt (if enabled) on the autofill page.

Code changes

The default autofill page AutofillChipersPage is correctly checking and asking for password reprompt.

3f86bb0cd7/src/App/Pages/Vault/AutofillCiphersPageViewModel.cs (L189-L192)

This feature is missing when searching for other items in the vault using the ChipersPage. This commit adds this check before doing any action (view/autofill/autofill & save)

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2401 **Author:** [@Marplex](https://github.com/Marplex) **Created:** 3/5/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-ask-reprompt-autofill` --- ### 📝 Commits (10+) - [`48a8d9a`](https://github.com/bitwarden/android/commit/48a8d9ae35726a08c05adf99e8cc9ad63772d620) Clipboard handling adjustments for Android 13 (#1947) - [`388ad4e`](https://github.com/bitwarden/android/commit/388ad4e840b2c7bebc351d17b83266e6566304b9) lib updates (#1949) - [`51a5f58`](https://github.com/bitwarden/android/commit/51a5f5825863e9cbbd010bc9a7249e43ddcc5f1b) Fixed vault filter display issue with personal ownership policy (#1950) - [`5579817`](https://github.com/bitwarden/android/commit/5579817f9f5661e63fe52b8e18c47319a2714fa7) Updating the release version check to use the new action (#1934) - [`f9cbe43`](https://github.com/bitwarden/android/commit/f9cbe43627ed5586facfb3e515f9c44ecd34fd30) [PIQ-3] Add Github Actions to help manage issues and PRs (#1948) - [`e51233b`](https://github.com/bitwarden/android/commit/e51233bf9b4bfccf0f9469126a230df62c1db27d) Update README and CONTRIBUTING to use contributing.bitwarden.com (#1932) - [`448758a`](https://github.com/bitwarden/android/commit/448758a697b3287bef3a84cdde14d4f934ded250) Additional logic around filter display (#1951) - [`c53a85c`](https://github.com/bitwarden/android/commit/c53a85cd505465b72e92bbe6a19eed465daccf2f) [SG-390] Fix for missing org items with single org & personal ownership enabled (#1953) - [`3aef86b`](https://github.com/bitwarden/android/commit/3aef86bd3402f21d2f14249dfa04f5f5e3a8e04a) [SG-386] iOS Update user state when coming from background (#1952) - [`f24388c`](https://github.com/bitwarden/android/commit/f24388c1b5f81cb85193aec1450934028a6d7203) separate init and showVaultFilter property set (#1954) ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/CiphersPageViewModel.cs` (+6 -0) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> This PR fixes the issue #1866. Now the app is asking for password reprompt (if enabled) on the autofill page. ## Code changes The default autofill page [AutofillChipersPage](https://github.com/bitwarden/mobile/blob/master/src/App/Pages/Vault/AutofillCiphersPage.xaml.cs) is correctly checking and asking for password reprompt. https://github.com/bitwarden/mobile/blob/3f86bb0cd7e33c29e7374c0caee402b9fd30386e/src/App/Pages/Vault/AutofillCiphersPageViewModel.cs#L189-L192 This feature is missing when searching for other items in the vault using the [ChipersPage](https://github.com/bitwarden/mobile/blob/master/src/App/Pages/Vault/CiphersPage.xaml.cs). This commit adds this check before doing any action (view/autofill/autofill & save) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3543
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?