github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2397] [MERGED] [PM-1271] Removed StorageMediatorOptions to plain parameters #3540

New Issue
Closed
opened 2025-11-26 23:34:08 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:34:08 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2397
Author: @fedemkr
Created: 3/2/2023
Status: ✅ Merged
Merged: 3/2/2023
Merged by: @fedemkr

Base: master ← Head: PM-1271-storage-mediator-option-params

📝 Commits (2)

  • b7a9cd6 PM-1271 Removed StorageMediatorOptions and go to a plain parameters based approach
  • 74411f8 Merge branch 'master' into PM-1271-storage-mediator-option-params

📊 Changes

3 files changed (+13 additions, -21 deletions)

View changed files

📝 src/Core/Abstractions/IStorageMediatorService.cs (+3 -3)
➖ src/Core/Services/StorageMediatorOptions.cs (+0 -8)
📝 src/Core/Services/StorageMediatorService.cs (+10 -10)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Removed the StorageMediatorOptions and replaced it with plain parameters approach

Code changes

  • StorageMediatorService: Changed methods to use plain parameters approach instead of the object
  • StorageMediatorOptions: Removed

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2397 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/2/2023 **Status:** ✅ Merged **Merged:** 3/2/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `PM-1271-storage-mediator-option-params` --- ### 📝 Commits (2) - [`b7a9cd6`](https://github.com/bitwarden/android/commit/b7a9cd63500f6337d4157c83f84966aa5f07e3eb) PM-1271 Removed StorageMediatorOptions and go to a plain parameters based approach - [`74411f8`](https://github.com/bitwarden/android/commit/74411f82720e91c7c1e25fbe907b2e3cfd5f4639) Merge branch 'master' into PM-1271-storage-mediator-option-params ### 📊 Changes **3 files changed** (+13 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Abstractions/IStorageMediatorService.cs` (+3 -3) ➖ `src/Core/Services/StorageMediatorOptions.cs` (+0 -8) 📝 `src/Core/Services/StorageMediatorService.cs` (+10 -10) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Removed the `StorageMediatorOptions` and replaced it with plain parameters approach ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **StorageMediatorService:** Changed methods to use plain parameters approach instead of the object * **StorageMediatorOptions:** Removed ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:08 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3540
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?