github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 21:16:29 -05:00
Code Issues 2.3k Packages Projects Releases 128 Wiki Activity

[PR #3540] [MERGED] [PM-9407] Confirm overwrite existing passkey on item listing #17005

New Issue
Closed
opened 2026-04-15 02:35:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 02:35:10 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3540
Author: @SaintPatrck
Created: 7/16/2024
Status: ✅ Merged
Merged: 7/18/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-9407/replace-existing-passkey-item-listing

📝 Commits (10+)

  • 9b67fdf [PM-8137] Introduce FIDO 2 user verification state tracking
  • 399e66e Merge branch 'main' into PM-8137/user-verification-state-tracking
  • 19b206e [PM-8137] Set initial FIDO 2 user verification state
  • 725da84 Merge branch 'main' into PM-8137/user-verification-state-tracking-main
  • a1ab306 [PM-8137] Only prompt for UV when not verified
  • bdc1b2c Merge remote-tracking branch 'refs/remotes/origin/main' into PM-8137/user-verification-state-tracking-item-listing
  • f0abb0d Merge branch 'main' into PM-8137/user-verification-state-tracking-item-listing
  • e5e2caa [PM-9407] Confirm overwrite existing passkey on item listing
  • 8523132 Merge branch 'main' into PM-9407/replace-existing-passkey-item-listing
  • 5b15811 Fix failing tests

📊 Changes

9 files changed (+243 additions, -16 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt (+18 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+43 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/util/CipherViewExtensionsTest.kt (+5 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/CipherViewUtil.kt (+1 -4)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModelTest.kt (+5 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt (+1 -4)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt (+34 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt (+133 -6)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt (+3 -0)

📄 Description

🎟️ Tracking

PM-9407

📔 Objective

During FIDO 2 credential registration, if the user selects a Cipher that already has a passkey associated they will be prompted to confirm they want to overwrite the existing passkey.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3540 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 7/16/2024 **Status:** ✅ Merged **Merged:** 7/18/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-9407/replace-existing-passkey-item-listing` --- ### 📝 Commits (10+) - [`9b67fdf`](https://github.com/bitwarden/android/commit/9b67fdfbc315309963422c22043b023986ac25b7) [PM-8137] Introduce FIDO 2 user verification state tracking - [`399e66e`](https://github.com/bitwarden/android/commit/399e66efdea38bc8df1c8b1317219ecc599807aa) Merge branch 'main' into PM-8137/user-verification-state-tracking - [`19b206e`](https://github.com/bitwarden/android/commit/19b206eaadb8f73e5d9b36ee4e0df124d6531975) [PM-8137] Set initial FIDO 2 user verification state - [`725da84`](https://github.com/bitwarden/android/commit/725da84cdabd300b8de5a08049222daf4b5df42c) Merge branch 'main' into PM-8137/user-verification-state-tracking-main - [`a1ab306`](https://github.com/bitwarden/android/commit/a1ab306c8f6f26692fe26041f94260e24be0186c) [PM-8137] Only prompt for UV when not verified - [`bdc1b2c`](https://github.com/bitwarden/android/commit/bdc1b2c42252ecb26f03e28bd29f9da856fcd62d) Merge remote-tracking branch 'refs/remotes/origin/main' into PM-8137/user-verification-state-tracking-item-listing - [`f0abb0d`](https://github.com/bitwarden/android/commit/f0abb0d0069dbac8a1c366f20568f77a84c78474) Merge branch 'main' into PM-8137/user-verification-state-tracking-item-listing - [`e5e2caa`](https://github.com/bitwarden/android/commit/e5e2caa56bb778775d96077e08094ad070d1fc71) [PM-9407] Confirm overwrite existing passkey on item listing - [`8523132`](https://github.com/bitwarden/android/commit/8523132968e0f68826fbd695b995ca474a164f69) Merge branch 'main' into PM-9407/replace-existing-passkey-item-listing - [`5b15811`](https://github.com/bitwarden/android/commit/5b15811565efe7d4d896db1e5a779be7cd8b0404) Fix failing tests ### 📊 Changes **9 files changed** (+243 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreen.kt` (+18 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+43 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/util/CipherViewExtensionsTest.kt` (+5 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/CipherViewUtil.kt` (+1 -4) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModelTest.kt` (+5 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt` (+1 -4) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingScreenTest.kt` (+34 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModelTest.kt` (+133 -6) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensionsTest.kt` (+3 -0) </details> ### 📄 Description ## 🎟️ Tracking PM-9407 ## 📔 Objective During FIDO 2 credential registration, if the user selects a Cipher that already has a passkey associated they will be prompted to confirm they want to overwrite the existing passkey. ## 📸 Screenshots <img width="378" alt="image" src="https://github.com/user-attachments/assets/a70ebad6-6aee-4ddb-bb2f-7547693e92b2"> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 02:35:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#17005
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?