github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2379] [MERGED] State migration storage key refinement #3532

New Issue
Closed
opened 2025-11-26 23:34:02 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:34:02 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2379
Author: @mpbw2
Created: 2/16/2023
Status: ✅ Merged
Merged: 2/16/2023
Merged by: @mpbw2

Base: master ← Head: techdebt/state-migration

📝 Commits (2)

  • c0667b9 State migration storage key refinement
  • 05312fe Merge branch 'master' into techdebt/state-migration

📊 Changes

3 files changed (+259 additions, -313 deletions)

View changed files

📝 src/Core/Constants.cs (+23 -23)
📝 src/Core/Services/StateMigrationService.cs (+66 -30)
📝 src/Core/Services/StateService.cs (+170 -260)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Future-proofing state migration from issues discovered during #2366 plus other cleanup

Code changes

  • StateMigrationService.cs: Converted references to Constants to self-contained V3Keys class to prevent future conflicts during subsequent migrations, and added region markers for clarity
  • StateService.cs: Converted key and options to inline where appropriate
  • Constants.cs: Converted static to const for consistency

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2379 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 2/16/2023 **Status:** ✅ Merged **Merged:** 2/16/2023 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `techdebt/state-migration` --- ### 📝 Commits (2) - [`c0667b9`](https://github.com/bitwarden/android/commit/c0667b9bc73b23369eea6dbfbf1f7ab0ecf7b465) State migration storage key refinement - [`05312fe`](https://github.com/bitwarden/android/commit/05312fe0ae94585536836aba13cd5adae6cc333f) Merge branch 'master' into techdebt/state-migration ### 📊 Changes **3 files changed** (+259 additions, -313 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Constants.cs` (+23 -23) 📝 `src/Core/Services/StateMigrationService.cs` (+66 -30) 📝 `src/Core/Services/StateService.cs` (+170 -260) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Future-proofing state migration from issues discovered during #2366 plus other cleanup ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **StateMigrationService.cs:** Converted references to `Constants` to self-contained `V3Keys` class to prevent future conflicts during subsequent migrations, and added region markers for clarity * **StateService.cs:** Converted `key` and `options` to inline where appropriate * **Constants.cs:** Converted `static` to `const` for consistency ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:02 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3532
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?