github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3532] [MERGED] [PM-8137] Perform FIDO 2 verification on item add/edit when required #23625

New Issue
Closed
opened 2026-04-16 23:39:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:39:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3532
Author: @SaintPatrck
Created: 7/15/2024
Status: ✅ Merged
Merged: 7/16/2024
Merged by: @SaintPatrck

Base: main ← Head: PM-8137/user-verification-state-tracking-add-edit-item

📝 Commits (10+)

  • cc3d4e9 Introduce FIDO 2 user verification to add edit item
  • 7999e66 Merge remote-tracking branch 'refs/remotes/origin/main' into PM-8137/user-verificatoin-add-edit-item
  • a7f9bf7 Update branch and handle UV not supported
  • 82cd7c9 Chop down call and correct null option handling
  • 2dca33d Docs
  • 7dcc56e Merge branch 'main' into PM-8137/user-verificatoin-add-edit-item
  • 8a09734 Merge branch 'main' into PM-8137/user-verificatoin-add-edit-item
  • 49b545e [PM-8137] Skip verification if verified during add/edit
  • db8cad6 Detekt fix
  • c237f22 Show FIDO 2 error dialog when UV not supported

📊 Changes

2 files changed (+138 additions, -51 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+13 -6)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt (+125 -45)

📄 Description

🎟️ Tracking

PM-8137

📔 Objective

Skip performing user verification for FIDO 2 operations on save when the user has previously performed a verifying action.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3532 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 7/15/2024 **Status:** ✅ Merged **Merged:** 7/16/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-8137/user-verification-state-tracking-add-edit-item` --- ### 📝 Commits (10+) - [`cc3d4e9`](https://github.com/bitwarden/android/commit/cc3d4e9632d577a1a555f14001c219dd9f4ec000) Introduce FIDO 2 user verification to add edit item - [`7999e66`](https://github.com/bitwarden/android/commit/7999e6672e1b599f0ae1e8e5c7a49a31808f71f9) Merge remote-tracking branch 'refs/remotes/origin/main' into PM-8137/user-verificatoin-add-edit-item - [`a7f9bf7`](https://github.com/bitwarden/android/commit/a7f9bf72ee788bcb1012d5d67dff7b6c160a96a8) Update branch and handle UV not supported - [`82cd7c9`](https://github.com/bitwarden/android/commit/82cd7c95ca93d754d163c49fa4e253e35c25fae0) Chop down call and correct null option handling - [`2dca33d`](https://github.com/bitwarden/android/commit/2dca33db49027f947c0128910dd6cf6c1a83aba2) Docs - [`7dcc56e`](https://github.com/bitwarden/android/commit/7dcc56e55a6911da12d4399c26bd6170bb98327f) Merge branch 'main' into PM-8137/user-verificatoin-add-edit-item - [`8a09734`](https://github.com/bitwarden/android/commit/8a09734f5afd8d50d9b7b81a2f82d3c862e51924) Merge branch 'main' into PM-8137/user-verificatoin-add-edit-item - [`49b545e`](https://github.com/bitwarden/android/commit/49b545e2824017829edcd796cd85d43b8406db03) [PM-8137] Skip verification if verified during add/edit - [`db8cad6`](https://github.com/bitwarden/android/commit/db8cad6ad98712c054a81203dcdd42bc4dbaac1c) Detekt fix - [`c237f22`](https://github.com/bitwarden/android/commit/c237f226609ec5b000f140ce64af8b40ee0223b9) Show FIDO 2 error dialog when UV not supported ### 📊 Changes **2 files changed** (+138 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+13 -6) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt` (+125 -45) </details> ### 📄 Description ## 🎟️ Tracking PM-8137 ## 📔 Objective Skip performing user verification for FIDO 2 operations on save when the user has previously performed a verifying action. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:39:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#23625
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?