github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 11:44:32 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2337] [CLOSED] [PS-2410] Remove unnecessary URI-pruning logic #3509

New Issue
Closed
opened 2025-11-26 23:33:44 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:33:44 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2337
Author: @nick-cd
Created: 2/2/2023
Status: ❌ Closed

Base: main ← Head: bugs/prune-uris

📝 Commits (10+)

  • 1bbe8d8 Bumped version to 2.18.1 (#1894)
  • c251b95 PS-77 Updated two-factor email request to include the device identifier to check whether to send the 2fa email because of a new device (#1895)
  • b081a8c fix a11y issue with hCaptcha on iOS (#1896)
  • 604e3b6 Remove testing requirements from pr template (#1901)
  • bcbc273 PS-591 Fix avoid ambiguous characters #1664 (#1906)
  • 22c7465 PS-518 - Add setting to block AppCenter / Analytics - Mobile (#1905)
  • a259560 PS-592 Mobile - Name field is not prioritised in search results (#1907)
  • 58d7b00 add master password reprompt to share sheet extension (#1922)
  • 7e9b739 PS-90: App keeps asking for 2FA even though I've checked the "remember me" checkbox (#1921)
  • 43e9515 [PS-672] Accessibility - File/Text controls unintuitive, "Text" accessible name incorrect (#1923)

📊 Changes

1 file changed (+0 additions, -10 deletions)

View changed files

📝 src/App/Pages/Vault/CipherAddEditPageViewModel.cs (+0 -10)

📄 Description

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc.)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Accompanies bitwarden/server#2661 whose goal is to remove unfilled URI entries on the user's behalf automatically.

Code changes

  • CipherAddEditPageViewModel.cs: removes redundant logic within the submitAsync() routine.

Screenshots

N/A

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2337 **Author:** [@nick-cd](https://github.com/nick-cd) **Created:** 2/2/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `bugs/prune-uris` --- ### 📝 Commits (10+) - [`1bbe8d8`](https://github.com/bitwarden/android/commit/1bbe8d8b985d2aefc4b0e91eaab96f69f70dbfc3) Bumped version to 2.18.1 (#1894) - [`c251b95`](https://github.com/bitwarden/android/commit/c251b950d1212436de43ff18149f04652ee8db74) PS-77 Updated two-factor email request to include the device identifier to check whether to send the 2fa email because of a new device (#1895) - [`b081a8c`](https://github.com/bitwarden/android/commit/b081a8c6347516e7ebe9577f4e40caf3421fe0c6) fix a11y issue with hCaptcha on iOS (#1896) - [`604e3b6`](https://github.com/bitwarden/android/commit/604e3b68922148c166fb890eebc7e6a062116d3e) Remove testing requirements from pr template (#1901) - [`bcbc273`](https://github.com/bitwarden/android/commit/bcbc2738ca43d73bd5fe53aaaaa5708cf6f5946b) PS-591 Fix avoid ambiguous characters #1664 (#1906) - [`22c7465`](https://github.com/bitwarden/android/commit/22c746543a2f41e38e076bdd4c8623c3bae6ad15) PS-518 - Add setting to block AppCenter / Analytics - Mobile (#1905) - [`a259560`](https://github.com/bitwarden/android/commit/a259560d290aca772793be03dcb3e76ca22a8c26) PS-592 Mobile - Name field is not prioritised in search results (#1907) - [`58d7b00`](https://github.com/bitwarden/android/commit/58d7b001a5bc8459bf2d4b40fe952b03a64506b8) add master password reprompt to share sheet extension (#1922) - [`7e9b739`](https://github.com/bitwarden/android/commit/7e9b7398c8564b197c149781a543b105481b2b9f) PS-90: App keeps asking for 2FA even though I've checked the "remember me" checkbox (#1921) - [`43e9515`](https://github.com/bitwarden/android/commit/43e9515a032e4cc60252cd6a96107fe6fb1d0282) [PS-672] Accessibility - File/Text controls unintuitive, "Text" accessible name incorrect (#1923) ### 📊 Changes **1 file changed** (+0 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/CipherAddEditPageViewModel.cs` (+0 -10) </details> ### 📄 Description ## Type of change ``` - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc.) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ``` ## Objective Accompanies bitwarden/server#2661 whose goal is to remove unfilled URI entries on the user's behalf automatically. ## Code changes - **CipherAddEditPageViewModel.cs:** removes redundant logic within the `submitAsync()` routine. ## Screenshots N/A --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:33:44 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3509
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?