github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-22 12:01:42 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3032] [MERGED] [PM-6428] Added ConditionedAwaiter to avoid race condition issue where HomePage navigation would run after the main navigation #34476

New Issue
Closed
opened 2026-04-21 02:03:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 02:03:34 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3032
Author: @dinisvieira
Created: 2/25/2024
Status: ✅ Merged
Merged: 2/26/2024
Merged by: @fedemkr

Base: feature/legacy-secure-storage ← Head: feature/legacy-secure-storage-conditioned-awaiter

📝 Commits (1)

  • c914200 Added ConditionedAwaiter to avoid race condition issue where HomePage navigation would execute after the main navigation

📊 Changes

5 files changed (+18 additions, -3 deletions)

View changed files

📝 src/Core/Abstractions/IConditionedAwaiterManager.cs (+2 -1)
📝 src/Core/Pages/Accounts/HomePage.xaml.cs (+4 -0)
📝 src/Core/Pages/AndroidNavigationRedirectPage.xaml.cs (+4 -0)
📝 src/Core/Services/ConditionedAwaiterManager.cs (+2 -1)
📝 src/Core/Utilities/AccountManagement/AccountsManager.cs (+6 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Try to ensure the main navigation always runs after the homepage navigation.

Code changes

Using the ConditionedAwaiterManager I initially tried using SetCompleted in the Window ctor but that was apparently to early still.
Moved it to HomePage after it "fires" it's own Navigation and that does seem to work.

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3032 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 2/25/2024 **Status:** ✅ Merged **Merged:** 2/26/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/legacy-secure-storage` ← **Head:** `feature/legacy-secure-storage-conditioned-awaiter` --- ### 📝 Commits (1) - [`c914200`](https://github.com/bitwarden/android/commit/c91420069c3f3e890b9e12893b18007b9d7f8539) Added ConditionedAwaiter to avoid race condition issue where HomePage navigation would execute after the main navigation ### 📊 Changes **5 files changed** (+18 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Abstractions/IConditionedAwaiterManager.cs` (+2 -1) 📝 `src/Core/Pages/Accounts/HomePage.xaml.cs` (+4 -0) 📝 `src/Core/Pages/AndroidNavigationRedirectPage.xaml.cs` (+4 -0) 📝 `src/Core/Services/ConditionedAwaiterManager.cs` (+2 -1) 📝 `src/Core/Utilities/AccountManagement/AccountsManager.cs` (+6 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Try to ensure the main navigation always runs after the homepage navigation. ## Code changes Using the ConditionedAwaiterManager I initially tried using SetCompleted in the Window ctor but that was apparently to early still. Moved it to HomePage after it "fires" it's own Navigation and that does seem to work. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 02:03:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#34476