github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1654] [MERGED] ui changes for lock screen if using key connector with biometrics #3032

New Issue
Closed
opened 2025-11-26 23:27:23 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:27:23 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1654
Author: @jlf0dev
Created: 11/19/2021
Status: ✅ Merged
Merged: 11/19/2021
Merged by: @jlf0dev

Base: master ← Head: feature/ui-lock-key-connector-biometrics

📝 Commits (1)

  • 78eda41 ui changes for lock screen if using key connector with biometrics

📊 Changes

5 files changed (+78 additions, -23 deletions)

View changed files

📝 src/App/Pages/Accounts/LockPage.xaml (+23 -10)
📝 src/App/Pages/Accounts/LockPage.xaml.cs (+17 -1)
📝 src/App/Pages/Accounts/LockPageViewModel.cs (+20 -12)
📝 src/App/Resources/AppResources.Designer.cs (+12 -0)
📝 src/App/Resources/AppResources.resx (+6 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

If a key connector user has biometrics set up on the lock screen, we want to hide the master password prompt. This change will impact both the lock screen authentication, and autofill authentication on Android.

If the user is using a PIN with biometrics, the screen should remain the same and prompt for PIN input.

Code changes

  • src/App/Pages/Accounts/LockPage.xaml: Altered padding to look decent if MP prompt is missing. Added a name to unlock button for hiding.
  • src/App/Pages/Accounts/LockPage.xaml.cs: Hide MP field and Unlock button if key connector is being used, moved biometric prompt to this codebehind so we can make UI changes faster.
  • src/App/Pages/Accounts/LockPageViewModel.cs: Created UsingKeyConnector property, additional ui changes if true
  • src/App/Resources/AppResources.resx: Added resource strings

Screenshots

Testing requirements

  • Lock screen while using key connector and biometrics
  • Lock screen while using key connector, biometrics, and PIN
  • Lock screen while not using key connector (biometrics and PIN enabled/disabled)
  • Android autofill authentication while using biometrics and with/without PIN

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1654 **Author:** [@jlf0dev](https://github.com/jlf0dev) **Created:** 11/19/2021 **Status:** ✅ Merged **Merged:** 11/19/2021 **Merged by:** [@jlf0dev](https://github.com/jlf0dev) **Base:** `master` ← **Head:** `feature/ui-lock-key-connector-biometrics` --- ### 📝 Commits (1) - [`78eda41`](https://github.com/bitwarden/android/commit/78eda4178614d7330e84fd356601b1212b30f4aa) ui changes for lock screen if using key connector with biometrics ### 📊 Changes **5 files changed** (+78 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LockPage.xaml` (+23 -10) 📝 `src/App/Pages/Accounts/LockPage.xaml.cs` (+17 -1) 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+20 -12) 📝 `src/App/Resources/AppResources.Designer.cs` (+12 -0) 📝 `src/App/Resources/AppResources.resx` (+6 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [x] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> If a key connector user has biometrics set up on the lock screen, we want to hide the master password prompt. This change will impact both the lock screen authentication, and autofill authentication on Android. If the user is using a PIN with biometrics, the screen should remain the same and prompt for PIN input. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/App/Pages/Accounts/LockPage.xaml:** Altered padding to look decent if MP prompt is missing. Added a name to unlock button for hiding. * **src/App/Pages/Accounts/LockPage.xaml.cs:** Hide MP field and Unlock button if key connector is being used, moved biometric prompt to this codebehind so we can make UI changes faster. * **src/App/Pages/Accounts/LockPageViewModel.cs:** Created `UsingKeyConnector` property, additional ui changes if `true` * **src/App/Resources/AppResources.resx:** Added resource strings ## Screenshots <!--Required for any UI changes. Delete if not applicable--> <img src="https://user-images.githubusercontent.com/24985544/142663823-597b3d72-c9fc-4c7a-bd6f-8da3b9c644d9.png" width="50%" height="50%"> ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> - Lock screen while using key connector and biometrics - Lock screen while using key connector, biometrics, and PIN - Lock screen while not using key connector (biometrics and PIN enabled/disabled) - Android autofill authentication while using biometrics and with/without PIN ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:27:23 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3032
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?