github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2912] [MERGED] [PM-4760] Admin Recovery Permissions prompted to set MP. #34383

New Issue
Closed
opened 2026-04-21 01:58:44 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 01:58:44 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2912
Author: @andrebispo5
Created: 12/21/2023
Status: ✅ Merged
Merged: 3/1/2024
Merged by: @andrebispo5

Base: main ← Head: auth/pm-4760/priv-elev-custom

📝 Commits (6)

  • 53883d2 [PM-4760] Add force password reset check on sync complete.
  • 5c38df7 Merge branch 'main' into auth/pm-4760/priv-elev-custom
  • 23f0480 [PM-4760] Log error on exception
  • 7938772 Merge branch 'main' into auth/pm-4760/priv-elev-custom
  • a5c4bb6 Merge branch 'main' into auth/pm-4760/priv-elev-custom
  • 7fb4ebd Merge branch 'main' into auth/pm-4760/priv-elev-custom

📊 Changes

1 file changed (+8 additions, -0 deletions)

View changed files

📝 src/Core/Pages/TabsPage.cs (+8 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

If elevating user’s role to Custom role with the “Manage Account Recovery” permission, the user needs to be prompted to set a master password.
This check is made on Sync.

Code changes

Add force password reset check on sync complete. This check also runs on TabsPage OnAppearing, we will leverage existing broadcast subscription to "synccomplete" to also check for password reset.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2912 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 12/21/2023 **Status:** ✅ Merged **Merged:** 3/1/2024 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `auth/pm-4760/priv-elev-custom` --- ### 📝 Commits (6) - [`53883d2`](https://github.com/bitwarden/android/commit/53883d2faa7da25550e1819572c047f50431a42b) [PM-4760] Add force password reset check on sync complete. - [`5c38df7`](https://github.com/bitwarden/android/commit/5c38df7f199a47f43906df4e21a78a468fea9694) Merge branch 'main' into auth/pm-4760/priv-elev-custom - [`23f0480`](https://github.com/bitwarden/android/commit/23f0480b854fa42b3aa3ac66fe30756805a0f7bf) [PM-4760] Log error on exception - [`7938772`](https://github.com/bitwarden/android/commit/7938772da5d53c88964fd86f4d4b93b8a1ad4748) Merge branch 'main' into auth/pm-4760/priv-elev-custom - [`a5c4bb6`](https://github.com/bitwarden/android/commit/a5c4bb69a106f568ba7651a8fdfd1193008f1fb8) Merge branch 'main' into auth/pm-4760/priv-elev-custom - [`7fb4ebd`](https://github.com/bitwarden/android/commit/7fb4ebd2b253f24f7abbb3402e0a5681a5c393d5) Merge branch 'main' into auth/pm-4760/priv-elev-custom ### 📊 Changes **1 file changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Pages/TabsPage.cs` (+8 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> If elevating user’s role to Custom role with the “Manage Account Recovery” permission, the user needs to be prompted to set a master password. This check is made on Sync. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Add force password reset check on sync complete. This check also runs on TabsPage OnAppearing, we will leverage existing broadcast subscription to "synccomplete" to also check for password reset. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 01:58:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#34383
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?