github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1471] [MERGED] Fix for Android crash when toggling system light/dark theme #2912

New Issue
Closed
opened 2025-11-26 23:25:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:50 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1471
Author: @mpbw2
Created: 7/21/2021
Status: ✅ Merged
Merged: 7/21/2021
Merged by: @mpbw2

Base: master ← Head: lib-updates

📝 Commits (1)

  • 9ee7aef keep app version at 2.11.1 for now

📊 Changes

8 files changed (+19 additions, -18 deletions)

View changed files

📝 src/Android/Android.csproj (+10 -9)
📝 src/App/App.csproj (+3 -3)
📝 src/iOS.Autofill/iOS.Autofill.csproj (+1 -1)
📝 src/iOS.Extension/iOS.Extension.csproj (+1 -1)
📝 src/iOS/iOS.csproj (+1 -1)
📝 store/google/Publisher/Publisher.csproj (+1 -1)
📝 test/Common/Common.csproj (+1 -1)
📝 test/Core.Test/Core.Test.csproj (+1 -1)

📄 Description

  • Bumped to latest Xamarin Forms to fix Android crash when toggling light/dark mode
  • Keep Xamarin.Google.Android.Material at 1.3.0.1 due to this issue
  • Added explicit Xamarin.AndroidX.Core dependency due to this issue (will create Asana ticket for future removal)
  • Restricted Xamarin.AndroidX.Core to 1.5.0 and added Xamarin.AndroidX.AppCompat.AppCompatResources due to this issue
  • Removed <AndroidLinkMode> from debug builds to fallback to default (same as release, which is SdkOnly instead of None) to catch library issues sneaking past developers. This will add a few seconds to the build time, but potentially save hours of debugging after the fact.
  • Updated other libs since this release will be regression tested
  • Some <PackageReference> cleanup in Android.cs.proj

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1471 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 7/21/2021 **Status:** ✅ Merged **Merged:** 7/21/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `lib-updates` --- ### 📝 Commits (1) - [`9ee7aef`](https://github.com/bitwarden/android/commit/9ee7aef3c4a8d42b803a0dbc885ade5b6122f227) keep app version at 2.11.1 for now ### 📊 Changes **8 files changed** (+19 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+10 -9) 📝 `src/App/App.csproj` (+3 -3) 📝 `src/iOS.Autofill/iOS.Autofill.csproj` (+1 -1) 📝 `src/iOS.Extension/iOS.Extension.csproj` (+1 -1) 📝 `src/iOS/iOS.csproj` (+1 -1) 📝 `store/google/Publisher/Publisher.csproj` (+1 -1) 📝 `test/Common/Common.csproj` (+1 -1) 📝 `test/Core.Test/Core.Test.csproj` (+1 -1) </details> ### 📄 Description - Bumped to latest Xamarin Forms to fix Android crash when toggling light/dark mode - Keep `Xamarin.Google.Android.Material` at `1.3.0.1` due to [this issue](https://github.com/xamarin/AndroidX/issues/335) - Added explicit `Xamarin.AndroidX.Core` dependency due to [this issue](https://github.com/xamarin/Xamarin.Forms/issues/14417) (will create Asana ticket for future removal) - Restricted `Xamarin.AndroidX.Core` to `1.5.0` and added `Xamarin.AndroidX.AppCompat.AppCompatResources` due to [this issue](https://github.com/xamarin/Xamarin.Forms/issues/14424) - Removed `<AndroidLinkMode>` from debug builds to fallback to default (same as release, which is `SdkOnly` instead of `None`) to catch library issues sneaking past developers. This will add a few seconds to the build time, but potentially save hours of debugging after the fact. - Updated other libs since this release will be regression tested - Some `<PackageReference>` cleanup in `Android.cs.proj` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:50 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2912
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?