github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2190] [MERGED] [SG-778] Adjust mobile client to handle previously-responded-to passwordless request #3416

New Issue
Closed
opened 2025-11-26 23:32:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:32:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2190
Author: @andrebispo5
Created: 11/14/2022
Status: ✅ Merged
Merged: 11/15/2022
Merged by: @andrebispo5

Base: master ← Head: feature/SG-778-passwordless-approved

📝 Commits (5)

  • 29f1026 [SG-778] Add properties to response model
  • e120546 [SG-778] Add validation for request already answered
  • a21b536 [SG-778] Remove unnecessary properties
  • 24de7d3 [SG-778] Remove unnecessary assignments
  • bf53179 Merge branch 'master' into feature/SG-778-passwordless-approved

📊 Changes

6 files changed (+24 additions, -3 deletions)

View changed files

📝 src/App/App.xaml.cs (+1 -1)
📝 src/App/Pages/Accounts/LoginPasswordlessRequestViewModel.cs (+1 -1)
📝 src/App/Pages/Accounts/LoginPasswordlessViewModel.cs (+8 -0)
📝 src/App/Resources/AppResources.Designer.cs (+9 -0)
📝 src/App/Resources/AppResources.resx (+3 -0)
📝 src/Core/Models/Response/PasswordlessLoginResponse.cs (+2 -1)

📄 Description

Depends on #https://github.com/bitwarden/server/pull/2412

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

When responding to a previously answered passwordless device, show a message saying the request is not longer valid.

Screenshots

image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2190 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 11/14/2022 **Status:** ✅ Merged **Merged:** 11/15/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `feature/SG-778-passwordless-approved` --- ### 📝 Commits (5) - [`29f1026`](https://github.com/bitwarden/android/commit/29f102677240f9e11e795db4a7671a5e94ff7d14) [SG-778] Add properties to response model - [`e120546`](https://github.com/bitwarden/android/commit/e1205465a8fe41d0561963c35153adcfa3cf256d) [SG-778] Add validation for request already answered - [`a21b536`](https://github.com/bitwarden/android/commit/a21b5367b158e371e39584d90aca42c94df4d137) [SG-778] Remove unnecessary properties - [`24de7d3`](https://github.com/bitwarden/android/commit/24de7d35fdc059d60ea5faea39e1384e38c7bdba) [SG-778] Remove unnecessary assignments - [`bf53179`](https://github.com/bitwarden/android/commit/bf53179918dfd6d5cdc413c306f9576d245ba67d) Merge branch 'master' into feature/SG-778-passwordless-approved ### 📊 Changes **6 files changed** (+24 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.xaml.cs` (+1 -1) 📝 `src/App/Pages/Accounts/LoginPasswordlessRequestViewModel.cs` (+1 -1) 📝 `src/App/Pages/Accounts/LoginPasswordlessViewModel.cs` (+8 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+9 -0) 📝 `src/App/Resources/AppResources.resx` (+3 -0) 📝 `src/Core/Models/Response/PasswordlessLoginResponse.cs` (+2 -1) </details> ### 📄 Description Depends on #https://github.com/bitwarden/server/pull/2412 ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> When responding to a previously answered passwordless device, show a message saying the request is not longer valid. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> <img width="435" alt="image" src="https://user-images.githubusercontent.com/4648522/201733773-d291e492-ab05-4423-bcc5-17c851ec0404.png"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:32:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3416
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?