github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-18 10:17:26 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3416] [MERGED] BIT-2440, BIT-2441: Clean up the way we update the account info after token refresh #122800

New Issue
Closed
opened 2026-06-12 00:42:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-12 00:42:04 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3416
Author: @david-livefront
Created: 7/8/2024
Status: ✅ Merged
Merged: 7/8/2024
Merged by: @david-livefront

Base: main ← Head: BIT-2440-BIT-2441-refresh-token-crash

📝 Commits (1)

  • 813b886 BIT-2440, BIT-2441: Clean up the way we update the account info after token refresh

📊 Changes

5 files changed (+32 additions, -234 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+12 -8)
➖ app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/RefreshTokenResponseExtensions.kt (+0 -39)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/disk/util/FakeAuthDiskSource.kt (+7 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+13 -28)
➖ app/src/test/java/com/x8bit/bitwarden/data/auth/repository/util/RefreshTokenResponseJsonTest.kt (+0 -159)

📄 Description

🎟️ Tracking

BIT-2440, BIT-2441

📔 Objective

This PR removes unnecessary code from the token refresh callback. This code used to be needed since the tokens were stored in the user state but no longer are. I have additionally added a check to validate that the user is still logged in when the callback returns, this enforces that we do not store token data for a user who has been logged out.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3416 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 7/8/2024 **Status:** ✅ Merged **Merged:** 7/8/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `BIT-2440-BIT-2441-refresh-token-crash` --- ### 📝 Commits (1) - [`813b886`](https://github.com/bitwarden/android/commit/813b8862eff1695725a5909d5e4ea274a90acf08) BIT-2440, BIT-2441: Clean up the way we update the account info after token refresh ### 📊 Changes **5 files changed** (+32 additions, -234 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+12 -8) ➖ `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/RefreshTokenResponseExtensions.kt` (+0 -39) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/disk/util/FakeAuthDiskSource.kt` (+7 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+13 -28) ➖ `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/util/RefreshTokenResponseJsonTest.kt` (+0 -159) </details> ### 📄 Description ## 🎟️ Tracking [BIT-2440](https://livefront.atlassian.net/browse/BIT-2440), [BIT-2441](https://livefront.atlassian.net/browse/BIT-2441) ## 📔 Objective This PR removes unnecessary code from the token refresh callback. This code used to be needed since the tokens were stored in the user state but no longer are. I have additionally added a check to validate that the user is still logged in when the callback returns, this enforces that we do not store token data for a user who has been logged out. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-12 00:42:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#122800