github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2179] [MERGED] [SG-808] Only show 'remove account' option if user is in Accounts list #3409

New Issue
Closed
opened 2025-11-26 23:32:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:32:20 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2179
Author: @differsthecat
Created: 11/9/2022
Status: ✅ Merged
Merged: 11/10/2022
Merged by: @differsthecat

Base: master ← Head: SG-808-2

📝 Commits (5)

  • 88a5069 Only show 'remove account' option if user is in Accounts list
  • 8cc55e8 Condense existing email logic
  • 5339afc Add line break
  • 40ae78d Condense to local variable
  • f254eaf Cleanup spacing

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+4 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Only show 'remove account' if the account already exists in the accounts list

Code changes

  • src/App/Pages/Accounts/LoginPageViewModel.cs: Add SavedEmail property that checks if the email belongs to an account in the accounts list and only show remove account if they are there.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2179 **Author:** [@differsthecat](https://github.com/differsthecat) **Created:** 11/9/2022 **Status:** ✅ Merged **Merged:** 11/10/2022 **Merged by:** [@differsthecat](https://github.com/differsthecat) **Base:** `master` ← **Head:** `SG-808-2` --- ### 📝 Commits (5) - [`88a5069`](https://github.com/bitwarden/android/commit/88a5069ad5f2d69c1f60785f50b9c3146fce58d6) Only show 'remove account' option if user is in Accounts list - [`8cc55e8`](https://github.com/bitwarden/android/commit/8cc55e8d662b76635706a6bfdb642b129991cccb) Condense existing email logic - [`5339afc`](https://github.com/bitwarden/android/commit/5339afc6bf17648fa33dad674a07fb4ba4d6cbf1) Add line break - [`40ae78d`](https://github.com/bitwarden/android/commit/40ae78d9e29f5e55fb8eb2395d4c601c6fe45d79) Condense to local variable - [`f254eaf`](https://github.com/bitwarden/android/commit/f254eaf2cee873726e5db57b92baf95a1bb48d0b) Cleanup spacing ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+4 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Only show 'remove account' if the account already exists in the accounts list ## Code changes * **src/App/Pages/Accounts/LoginPageViewModel.cs:** Add `SavedEmail` property that checks if the email belongs to an account in the accounts list and only show `remove account` if they are there. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:32:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3409
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?