github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2368] [MERGED] [SG-1022] Update min password requirements to 12 char #34024

New Issue
Closed
opened 2026-04-21 01:42:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 01:42:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2368
Author: @BrandonM-Bitwarden
Created: 2/14/2023
Status: ✅ Merged
Merged: 2/16/2023
Merged by: @BrandonM-Bitwarden

Base: master ← Head: changes/SG-1022

📝 Commits (3)

📊 Changes

6 files changed (+28 additions, -27 deletions)

View changed files

📝 src/App/Pages/Accounts/BaseChangePasswordViewModel.cs (+1 -1)
📝 src/App/Pages/Accounts/RegisterPageViewModel.cs (+1 -1)
📝 src/App/Pages/Accounts/SetPasswordPageViewModel.cs (+1 -1)
📝 src/App/Resources/AppResources.Designer.cs (+21 -20)
📝 src/App/Resources/AppResources.resx (+3 -3)
📝 src/Core/Constants.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Code changes

Updates the minimum password length to 12.

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2368 **Author:** [@BrandonM-Bitwarden](https://github.com/BrandonM-Bitwarden) **Created:** 2/14/2023 **Status:** ✅ Merged **Merged:** 2/16/2023 **Merged by:** [@BrandonM-Bitwarden](https://github.com/BrandonM-Bitwarden) **Base:** `master` ← **Head:** `changes/SG-1022` --- ### 📝 Commits (3) - [`3d055ed`](https://github.com/bitwarden/android/commit/3d055ed8b96cb0009b4c9bcdf268462554c620f8) work: adjusted numbers to 12 - [`df61d3d`](https://github.com/bitwarden/android/commit/df61d3d4fb6315f83e7335958cb92786954379fa) work: made string dynamic - [`4dcd402`](https://github.com/bitwarden/android/commit/4dcd4022ff6f96c5f7bc555290f512bfea2bf60e) fix: spaces ### 📊 Changes **6 files changed** (+28 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/BaseChangePasswordViewModel.cs` (+1 -1) 📝 `src/App/Pages/Accounts/RegisterPageViewModel.cs` (+1 -1) 📝 `src/App/Pages/Accounts/SetPasswordPageViewModel.cs` (+1 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+21 -20) 📝 `src/App/Resources/AppResources.resx` (+3 -3) 📝 `src/Core/Constants.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [x] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> ## Code changes Updates the minimum password length to 12. * **file.ext:** Description of what was changed and why ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 01:42:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#34024
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?