github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #2144] [MERGED] [SG-747] Add Android QA build to mobile build pipeline #3385

New Issue
Closed
opened 2025-11-26 23:32:01 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:32:01 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2144
Author: @andrebispo5
Created: 10/20/2022
Status: ✅ Merged
Merged: 10/21/2022
Merged by: @andrebispo5

Base: feature/cake-build ← Head: feature/cake-build-apk-path

📝 Commits (10+)

📊 Changes

1 file changed (+48 additions, -34 deletions)

View changed files

📝 .github/workflows/build.yml (+48 -34)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Workflow needs to create 2 android apks, which can be installed side-by-side (prod and qa) and each receives push notifications from the respective environment.

Code changes

  • Decrypt Secrets step: Separated into two steps. Google-Services file is only decrypted in prod to allow the qa build to receive notifications from the QA Cloud.
  • Deploy to PlayStore step: Before fix, if condition was always returning true.

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2144 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 10/20/2022 **Status:** ✅ Merged **Merged:** 10/21/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `feature/cake-build` ← **Head:** `feature/cake-build-apk-path` --- ### 📝 Commits (10+) - [`19f81b5`](https://github.com/bitwarden/android/commit/19f81b53b3756c28b28393e8a413fe8ec72137bd) Add checkout depth - [`6ff4d9f`](https://github.com/bitwarden/android/commit/6ff4d9f448995b3b3c9e79f07863503a2724739b) Build and upload QA artifacts - [`70d406d`](https://github.com/bitwarden/android/commit/70d406dec6dba02401d170b88b755d7ba7ce30da) Remove missing .aab - [`4ae61ac`](https://github.com/bitwarden/android/commit/4ae61ac29f0d6999f59a6425bba9efbc3dd21ef2) Merge branch 'feature/cake-build' into cake-build-fix-git-error - [`0be3ffb`](https://github.com/bitwarden/android/commit/0be3ffb2be7900f7b18a3e99cd7a168f3f27671d) Update build.yml - [`fcd843a`](https://github.com/bitwarden/android/commit/fcd843a1b678b43291c5cbef67af7f886b022134) Try correct path - [`3acdfa1`](https://github.com/bitwarden/android/commit/3acdfa1937034c31c29cae5d2f6902859d18d0ee) Update path - [`055453a`](https://github.com/bitwarden/android/commit/055453ae585735e598206a3a80b9b47e5df7937b) Update path - [`50600a3`](https://github.com/bitwarden/android/commit/50600a33924daa3cda3d49e4a4c1d1900e19a97e) Update paths - [`ba38017`](https://github.com/bitwarden/android/commit/ba38017bcd93468fc0642f5a6c46558b6a19b1f4) Update var names ### 📊 Changes **1 file changed** (+48 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+48 -34) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [X] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Workflow needs to create 2 android apks, which can be installed side-by-side (`prod` and `qa`) and each receives push notifications from the respective environment. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **Decrypt Secrets step:** Separated into two steps. Google-Services file is only decrypted in `prod` to allow the `qa` build to receive notifications from the QA Cloud. * **Deploy to PlayStore step:** Before fix, if condition was always returning true. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:32:01 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3385
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?