github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2100] [MERGED] Passwordless feature branch PR #3350

New Issue
Closed
opened 2025-11-26 23:31:34 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:34 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2100
Author: @andrebispo5
Created: 9/26/2022
Status: ✅ Merged
Merged: 9/26/2022
Merged by: @andrebispo5

Base: master ← Head: feature/feature-passwordless-login

📝 Commits (9)

  • 4a0d969 [SG-471] Passwordless device login screen (#2017)
  • f573e81 [SG-381] Passwordless - Add setting to Mobile (#2037)
  • a85da1f Merge branch 'master' into feature/feature-passwordless-login
  • 32f1c5a [SG-408] Implement passwordless api methods (#2055)
  • 056d28b [SG-472] Add configuration for new notification type (#2056)
  • 3d96c1f [SG-169] End-to-end testing refactor. (#2073)
  • 82462c4 [SG-169] Passwordless demo change requests (#2079)
  • 5d13cac Merge branch 'master' into feature/feature-passwordless-login
  • 2aa2c0d Merge branch 'master' into feature/feature-passwordless-login

📊 Changes

35 files changed (+852 additions, -30 deletions)

View changed files

📝 src/Android/MainActivity.cs (+21 -0)
📝 src/Android/Push/FirebaseMessagingService.cs (+24 -15)
📝 src/Android/Services/AndroidPushNotificationService.cs (+38 -0)
📝 src/Android/Services/DeviceActionService.cs (+9 -0)
📝 src/App/Abstractions/IDeviceActionService.cs (+1 -0)
📝 src/App/Abstractions/IPushNotificationService.cs (+5 -1)
📝 src/App/App.csproj (+3 -0)
📝 src/App/App.xaml.cs (+58 -5)
➕ src/App/Pages/Accounts/LoginPasswordlessPage.xaml (+85 -0)
➕ src/App/Pages/Accounts/LoginPasswordlessPage.xaml.cs (+31 -0)
➕ src/App/Pages/Accounts/LoginPasswordlessViewModel.cs (+126 -0)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+42 -1)
📝 src/App/Resources/AppResources.Designer.cs (+121 -0)
📝 src/App/Resources/AppResources.resx (+60 -0)
📝 src/App/Services/NoopPushNotificationService.cs (+11 -1)
📝 src/App/Services/PushNotificationListenerService.cs (+26 -0)
📝 src/App/Styles/Black.xaml (+1 -1)
📝 src/App/Styles/Dark.xaml (+1 -1)
📝 src/App/Styles/Light.xaml (+1 -1)
📝 src/App/Styles/Nord.xaml (+1 -1)

...and 15 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

PR to merge passwordless feature branch into master.
All changes in this PR were previously approved by other PRs.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2100 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 9/26/2022 **Status:** ✅ Merged **Merged:** 9/26/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `feature/feature-passwordless-login` --- ### 📝 Commits (9) - [`4a0d969`](https://github.com/bitwarden/android/commit/4a0d96997b7217f4995e6d9205e0b431375c6cb0) [SG-471] Passwordless device login screen (#2017) - [`f573e81`](https://github.com/bitwarden/android/commit/f573e8188ddbca16965ef98d0c934eb9186cd86a) [SG-381] Passwordless - Add setting to Mobile (#2037) - [`a85da1f`](https://github.com/bitwarden/android/commit/a85da1f1874738a26ffd05654790a28f0e1810f5) Merge branch 'master' into feature/feature-passwordless-login - [`32f1c5a`](https://github.com/bitwarden/android/commit/32f1c5afe1a5280314054cd9e34c0672fafe28f4) [SG-408] Implement passwordless api methods (#2055) - [`056d28b`](https://github.com/bitwarden/android/commit/056d28bbe3907eedc4452681033a19ea223ed34b) [SG-472] Add configuration for new notification type (#2056) - [`3d96c1f`](https://github.com/bitwarden/android/commit/3d96c1f59ebd3dd7fa273f8f98759a2f491c17b3) [SG-169] End-to-end testing refactor. (#2073) - [`82462c4`](https://github.com/bitwarden/android/commit/82462c4dbf0daab3ee1d289422b2151f76df5d22) [SG-169] Passwordless demo change requests (#2079) - [`5d13cac`](https://github.com/bitwarden/android/commit/5d13cac1949739bceefed29f4e9cecf5fa5805b8) Merge branch 'master' into feature/feature-passwordless-login - [`2aa2c0d`](https://github.com/bitwarden/android/commit/2aa2c0d12e6a2a557dfa4c1b00c159cbe6f09978) Merge branch 'master' into feature/feature-passwordless-login ### 📊 Changes **35 files changed** (+852 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainActivity.cs` (+21 -0) 📝 `src/Android/Push/FirebaseMessagingService.cs` (+24 -15) 📝 `src/Android/Services/AndroidPushNotificationService.cs` (+38 -0) 📝 `src/Android/Services/DeviceActionService.cs` (+9 -0) 📝 `src/App/Abstractions/IDeviceActionService.cs` (+1 -0) 📝 `src/App/Abstractions/IPushNotificationService.cs` (+5 -1) 📝 `src/App/App.csproj` (+3 -0) 📝 `src/App/App.xaml.cs` (+58 -5) ➕ `src/App/Pages/Accounts/LoginPasswordlessPage.xaml` (+85 -0) ➕ `src/App/Pages/Accounts/LoginPasswordlessPage.xaml.cs` (+31 -0) ➕ `src/App/Pages/Accounts/LoginPasswordlessViewModel.cs` (+126 -0) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+42 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+121 -0) 📝 `src/App/Resources/AppResources.resx` (+60 -0) 📝 `src/App/Services/NoopPushNotificationService.cs` (+11 -1) 📝 `src/App/Services/PushNotificationListenerService.cs` (+26 -0) 📝 `src/App/Styles/Black.xaml` (+1 -1) 📝 `src/App/Styles/Dark.xaml` (+1 -1) 📝 `src/App/Styles/Light.xaml` (+1 -1) 📝 `src/App/Styles/Nord.xaml` (+1 -1) _...and 15 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> PR to merge passwordless feature branch into `master`. All changes in this PR were previously approved by other PRs. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:34 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3350
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?