[PR #2045] [MERGED] [PS-1353] Add support for the Neeva app #3317

Closed
opened 2025-11-26 23:31:09 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2045
Author: @dan-alcantara-neeva
Created: 8/22/2022
Status: Merged
Merged: 12/28/2022
Merged by: @djsmith85

Base: masterHead: master


📝 Commits (3)

  • fa52ce2 Add support for the Neeva app
  • e3eb6c7 Merge branch 'master' into master
  • 6728f4b Merge branch 'master' into master

📊 Changes

3 files changed (+5 additions, -0 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+1 -0)
📝 src/Android/Autofill/AutofillHelpers.cs (+1 -0)
📝 src/Android/Resources/xml/autofillservice.xml (+3 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add support for the Neeva app.
https://community.bitwarden.com/t/adding-support-on-android-for-the-neeva-browser/43757

Code changes

Copied and tweaked https://github.com/bitwarden/mobile/pull/1855/files:

  • AccessibilityHelpers.cs was adjusted to be able to find the View ID of a TextView that contains the full URL of the page.
  • AutofillHelpers.cs and autofillservice.xml were edited to allow working with the Neeva app's package.

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2045 **Author:** [@dan-alcantara-neeva](https://github.com/dan-alcantara-neeva) **Created:** 8/22/2022 **Status:** ✅ Merged **Merged:** 12/28/2022 **Merged by:** [@djsmith85](https://github.com/djsmith85) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`fa52ce2`](https://github.com/bitwarden/android/commit/fa52ce2662d6748e4f35230d0ab99bd485cc141c) Add support for the Neeva app - [`e3eb6c7`](https://github.com/bitwarden/android/commit/e3eb6c75e73eee4b2bf3eb727385c38535cade9e) Merge branch 'master' into master - [`6728f4b`](https://github.com/bitwarden/android/commit/6728f4bfd02c04c997a55c4854a8ec082312d59f) Merge branch 'master' into master ### 📊 Changes **3 files changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+1 -0) 📝 `src/Android/Autofill/AutofillHelpers.cs` (+1 -0) 📝 `src/Android/Resources/xml/autofillservice.xml` (+3 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Add support for the [Neeva app](https://play.google.com/store/apps/details?id=com.neeva.app). https://community.bitwarden.com/t/adding-support-on-android-for-the-neeva-browser/43757 ## Code changes Copied and tweaked https://github.com/bitwarden/mobile/pull/1855/files: * `AccessibilityHelpers.cs` was adjusted to be able to find the View ID of a TextView that contains the full URL of the page. * `AutofillHelpers.cs` and `autofillservice.xml` were edited to allow working with the Neeva app's package. ## Before you submit - [X] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:09 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3317