github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1889] [MERGED] TDL-13 Removed workaround of null reference on LabelRenderer #3202

New Issue
Closed
opened 2025-11-26 23:29:37 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:37 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1889
Author: @fedemkr
Created: 4/25/2022
Status: ✅ Merged
Merged: 4/25/2022
Merged by: @fedemkr

Base: master ← Head: TDL-13-remove-workaround-label-renderer-crash

📝 Commits (1)

  • 97753f0 TDL-13 Removed workaround of null reference on LabelRenderer given that Xamarin forms has been updated with the fix

📊 Changes

1 file changed (+1 additions, -12 deletions)

View changed files

📝 src/iOS.Core/Renderers/CustomLabelRenderer.cs (+1 -12)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Removed workaround of null reference on LabelRenderer given that Xamarin.Forms package has been updated and already includes the fix.

Code changes

  • CustomLabelRenderer.cs: Removed try...catch that was the workaround for the issue.

Testing requirements

The app should not crash on the same tests as #1690

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1889 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 4/25/2022 **Status:** ✅ Merged **Merged:** 4/25/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `TDL-13-remove-workaround-label-renderer-crash` --- ### 📝 Commits (1) - [`97753f0`](https://github.com/bitwarden/android/commit/97753f00a21d34e92e7321da0a94adc923d9466d) TDL-13 Removed workaround of null reference on LabelRenderer given that Xamarin forms has been updated with the fix ### 📊 Changes **1 file changed** (+1 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Core/Renderers/CustomLabelRenderer.cs` (+1 -12) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Removed workaround of null reference on `LabelRenderer` given that [Xamarin.Forms package has been updated](https://github.com/xamarin/Xamarin.Forms/releases/tag/release-5.0.0-sr9) and already includes the fix. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CustomLabelRenderer.cs:** Removed try...catch that was the workaround for the issue. ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> The app should not crash on the same tests as #1690 ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3202
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?