github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-17 12:36:15 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #1838] [MERGED] Layout/Accessibility fixes for account switching list #3170

New Issue
Closed
opened 2025-11-26 23:29:12 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:12 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1838
Author: @mpbw2
Created: 3/10/2022
Status: ✅ Merged
Merged: 3/10/2022
Merged by: @mpbw2

Base: master ← Head: accountlist-layout-fixes

📝 Commits (1)

  • 139e63f fixes for font cutoff on samsung devices

📊 Changes

4 files changed (+41 additions, -11 deletions)

View changed files

📝 src/App/Controls/AccountViewCell/AccountViewCell.xaml (+7 -7)
📝 src/App/Styles/Android.xaml (+14 -2)
📝 src/App/Styles/Base.xaml (+8 -0)
📝 src/App/Styles/iOS.xaml (+12 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Depending on the configuration it was possible for text in the account list to be slightly cut off at the bottom on Samsung phones. Fixing it required changes to the account list styling across the board, resulting in a bit more visual consistency between platforms.

Code changes

  • Base/Android/iOS.xaml.ext: Added new accountlist-title and accountlist-sub Label styles to allow variations in sizing, also changed a few instances of FontSize 18 to Medium in Button styles to respect system font sizes
  • AccountViewCell.xaml: Apply the new StyleClass

Screenshots

See https://app.asana.com/0/1201803072708593/1200900473757531

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1838 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 3/10/2022 **Status:** ✅ Merged **Merged:** 3/10/2022 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `accountlist-layout-fixes` --- ### 📝 Commits (1) - [`139e63f`](https://github.com/bitwarden/android/commit/139e63f2cabbc2bb821e82397a2ed0d408484e79) fixes for font cutoff on samsung devices ### 📊 Changes **4 files changed** (+41 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/AccountViewCell/AccountViewCell.xaml` (+7 -7) 📝 `src/App/Styles/Android.xaml` (+14 -2) 📝 `src/App/Styles/Base.xaml` (+8 -0) 📝 `src/App/Styles/iOS.xaml` (+12 -2) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Depending on the configuration it was possible for text in the account list to be slightly cut off at the bottom on Samsung phones. Fixing it required changes to the account list styling across the board, resulting in a bit more visual consistency between platforms. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **Base/Android/iOS.xaml.ext:** Added new `accountlist-title` and `accountlist-sub` Label styles to allow variations in sizing, also changed a few instances of FontSize `18` to `Medium` in `Button` styles to respect system font sizes * **AccountViewCell.xaml:** Apply the new `StyleClass` ## Screenshots <!--Required for any UI changes. Delete if not applicable--> See https://app.asana.com/0/1201803072708593/1200900473757531 ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:12 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3170
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?