github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-18 14:19:36 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #3170] [MERGED] [PM-7257] android add support for web authn resident key credential property in our net mobile app 2 #23446

New Issue
Closed
opened 2026-04-16 23:31:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 23:31:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3170
Author: @coroiu
Created: 4/18/2024
Status: ✅ Merged
Merged: 4/19/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: PM-7257-android-add-support-for-web-authn-resident-key-credential-property-in-our-net-mobile-app-2

📝 Commits (3)

  • 0bfb505 [PM-7257] feat: add ability to override clientDataHash
  • f577a4d [PM-7257] feat: add support for clientDataHash and extensions
  • e823846 PM-7257 Updated the origin to be the correct one and not the android one to be passed to the Fido2Client

📊 Changes

12 files changed (+217 additions, -82 deletions)

View changed files

📝 src/App/Platforms/Android/Autofill/CredentialHelpers.cs (+39 -6)
📝 src/App/Platforms/Android/Autofill/CredentialProviderSelectionActivity.cs (+10 -9)
📝 src/Core/Abstractions/IFido2ClientService.cs (+2 -2)
📝 src/Core/Abstractions/IFido2MediatorService.cs (+2 -2)
📝 src/Core/Services/Fido2AuthenticatorService.cs (+2 -2)
📝 src/Core/Services/Fido2ClientService.cs (+29 -21)
📝 src/Core/Services/Fido2MediatorService.cs (+6 -6)
📝 src/Core/Utilities/Fido2/Fido2AuthenticatorGetAssertionResult.cs (+1 -10)
📝 src/Core/Utilities/Fido2/Fido2ClientAssertCredentialResult.cs (+7 -8)
➕ src/Core/Utilities/Fido2/Fido2SelectedCredential.cs (+10 -0)
📝 test/Core.Test/Services/Fido2ClientAssertCredentialTests.cs (+65 -16)
📝 test/Core.Test/Services/Fido2ClientCreateCredentialTests.cs (+44 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This redirects all android fido2 calls to the Fido2Client, and correctly maps to/from extension objects

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3170 **Author:** [@coroiu](https://github.com/coroiu) **Created:** 4/18/2024 **Status:** ✅ Merged **Merged:** 4/19/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `PM-7257-android-add-support-for-web-authn-resident-key-credential-property-in-our-net-mobile-app-2` --- ### 📝 Commits (3) - [`0bfb505`](https://github.com/bitwarden/android/commit/0bfb50507e8f7c251d797c805d5c98a51451ad2d) [PM-7257] feat: add ability to override `clientDataHash` - [`f577a4d`](https://github.com/bitwarden/android/commit/f577a4d5983cc101cdb7c624201fe0150d51db17) [PM-7257] feat: add support for clientDataHash and extensions - [`e823846`](https://github.com/bitwarden/android/commit/e8238466f6294e49341c832139c9170a22e0743d) PM-7257 Updated the origin to be the correct one and not the android one to be passed to the Fido2Client ### 📊 Changes **12 files changed** (+217 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Platforms/Android/Autofill/CredentialHelpers.cs` (+39 -6) 📝 `src/App/Platforms/Android/Autofill/CredentialProviderSelectionActivity.cs` (+10 -9) 📝 `src/Core/Abstractions/IFido2ClientService.cs` (+2 -2) 📝 `src/Core/Abstractions/IFido2MediatorService.cs` (+2 -2) 📝 `src/Core/Services/Fido2AuthenticatorService.cs` (+2 -2) 📝 `src/Core/Services/Fido2ClientService.cs` (+29 -21) 📝 `src/Core/Services/Fido2MediatorService.cs` (+6 -6) 📝 `src/Core/Utilities/Fido2/Fido2AuthenticatorGetAssertionResult.cs` (+1 -10) 📝 `src/Core/Utilities/Fido2/Fido2ClientAssertCredentialResult.cs` (+7 -8) ➕ `src/Core/Utilities/Fido2/Fido2SelectedCredential.cs` (+10 -0) 📝 `test/Core.Test/Services/Fido2ClientAssertCredentialTests.cs` (+65 -16) 📝 `test/Core.Test/Services/Fido2ClientCreateCredentialTests.cs` (+44 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective This redirects all android fido2 calls to the `Fido2Client`, and correctly maps to/from extension objects ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 23:31:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#23446
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?