github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-17 12:36:15 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #1776] [MERGED] Build: Upload dSYMs to AppCenter #3116

New Issue
Closed
opened 2025-11-26 23:28:30 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:30 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1776
Author: @fedemkr
Created: 2/14/2022
Status: ✅ Merged
Merged: 2/14/2022
Merged by: @fedemkr

Base: master ← Head: add-dsym-build

📝 Commits (10+)

  • c578899 Added dsym artifact to be uploaded alongside with the ipa o the build.yml
  • 02bb6ef Added dsym artifact to be uploaded alongside with the ipa o the build.yml
  • 6c13692 Fixed build.yml dsym artifact
  • c2f137d Merge branch 'master' into add-dsym-build
  • 554c444 Fix upload dsym build.yml
  • 648fa44 Fix build.yml to check what gets exported and after this will become the adjustment for the dsym (disabling Android build for this test)
  • 9d5c5aa Fix build.yml to copy all dsyms and artifact them (disabling Android build for this test)
  • 6619a9d Fix build.yml to only copy all dsyms and ipa and artifact them (disabling Android build for this test)
  • 2d7699d Merge branch 'master' into add-dsym-build
  • c43c5da Added Appcenterr CLI and upload missing symbols for dSYM to the build

📊 Changes

1 file changed (+50 additions, -3 deletions)

View changed files

📝 .github/workflows/build.yml (+50 -3)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Upload dSYM symbols to AppCenter so we can unsymbolicate crashes from now on.

Code changes

  • build.yml: Added tasks to copy the dSYM files, install the AppCenter CLI and upload the dSYM files.

Testing requirements

After a successful build on master, rc or hotfix, dSYM symbols of that build should be uploaded to AppCenter.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1776 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 2/14/2022 **Status:** ✅ Merged **Merged:** 2/14/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `add-dsym-build` --- ### 📝 Commits (10+) - [`c578899`](https://github.com/bitwarden/android/commit/c578899fcee29002847ac4b18f6b5768a083b333) Added dsym artifact to be uploaded alongside with the ipa o the build.yml - [`02bb6ef`](https://github.com/bitwarden/android/commit/02bb6ef15b9c43697176d57d728c74c394086f68) Added dsym artifact to be uploaded alongside with the ipa o the build.yml - [`6c13692`](https://github.com/bitwarden/android/commit/6c13692e675d71f16ae1504d7d699dfa797878ad) Fixed build.yml dsym artifact - [`c2f137d`](https://github.com/bitwarden/android/commit/c2f137d8d6c89008c339932ba44f996e6232c2b3) Merge branch 'master' into add-dsym-build - [`554c444`](https://github.com/bitwarden/android/commit/554c444644943664efee039b07b1671a55fad2ac) Fix upload dsym build.yml - [`648fa44`](https://github.com/bitwarden/android/commit/648fa44f5b38be16ebb60f6a8faa76759f994fdf) Fix build.yml to check what gets exported and after this will become the adjustment for the dsym (disabling Android build for this test) - [`9d5c5aa`](https://github.com/bitwarden/android/commit/9d5c5aa07cf2fba47f2f59c4661db6ee8c82662c) Fix build.yml to copy all dsyms and artifact them (disabling Android build for this test) - [`6619a9d`](https://github.com/bitwarden/android/commit/6619a9d7f22f982d7cee2db9ff0603fa29a3676a) Fix build.yml to only copy all dsyms and ipa and artifact them (disabling Android build for this test) - [`2d7699d`](https://github.com/bitwarden/android/commit/2d7699dd66041fcf82bda16c92f993c6fd35f84f) Merge branch 'master' into add-dsym-build - [`c43c5da`](https://github.com/bitwarden/android/commit/c43c5da3a0c980c0b5cc65b5e906de9043e07141) Added Appcenterr CLI and upload missing symbols for dSYM to the build ### 📊 Changes **1 file changed** (+50 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+50 -3) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Upload dSYM symbols to AppCenter so we can unsymbolicate crashes from now on. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **build.yml:** Added tasks to copy the dSYM files, install the AppCenter CLI and upload the dSYM files. ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> After a successful build on `master`, `rc` or `hotfix`, dSYM symbols of that build should be uploaded to AppCenter. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:30 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3116
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?