github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-18 14:19:36 -05:00
Code Issues 1.3k Packages Projects Releases 125 Wiki Activity

[PR #3116] [MERGED] [PM-6655] Add null fallback cipher name on passkeys #10175

New Issue
Closed
opened 2026-04-11 02:37:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-11 02:37:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3116
Author: @fedemkr
Created: 3/26/2024
Status: ✅ Merged
Merged: 3/27/2024
Merged by: @vvolkgang

Base: feature/maui-migration-passkeys ← Head: vault/pm-6655/add-null-fallback-item-name-passkeys

📝 Commits (2)

  • 73cd6f4 PM-6655 Fixed fallback value on passkeys to take into account CipherView.Name. Also removed non-discoverable passkey filter on adding credentials to the ASStore and also added the fallback consideration on the passkeys list iOS extension
  • 86f85cc PM-6655 Restored non-discoverable filter on credentials set for ASStore on this PR

📊 Changes

5 files changed (+30 additions, -15 deletions)

View changed files

📝 src/Core/Models/View/CipherView.cs (+11 -0)
📝 src/Core/Models/View/LoginView.cs (+0 -13)
📝 src/iOS.Autofill/Utilities/BaseLoginListTableSource.cs (+15 -0)
📝 src/iOS.Core/Utilities/ASHelpers.cs (+1 -1)
📝 src/iOS.Core/Views/ExtensionTableSource.cs (+3 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

If all usernames are null on a cipher item that has passkeys, then Cipher.Name should be displayed for username.

Code changes

  • CipherView: Moved method to get the Username and take into account Cipher.Name as a possible fallback.
  • BaseLoginListTableSource: Take into account username fallbacks for passkey items.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3116 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/26/2024 **Status:** ✅ Merged **Merged:** 3/27/2024 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `feature/maui-migration-passkeys` ← **Head:** `vault/pm-6655/add-null-fallback-item-name-passkeys` --- ### 📝 Commits (2) - [`73cd6f4`](https://github.com/bitwarden/android/commit/73cd6f4c97bd658cc2def87423b06fad771e0902) PM-6655 Fixed fallback value on passkeys to take into account CipherView.Name. Also removed non-discoverable passkey filter on adding credentials to the ASStore and also added the fallback consideration on the passkeys list iOS extension - [`86f85cc`](https://github.com/bitwarden/android/commit/86f85cc984fdaae877c4e755b2d0da1cbd48dc0e) PM-6655 Restored non-discoverable filter on credentials set for ASStore on this PR ### 📊 Changes **5 files changed** (+30 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Models/View/CipherView.cs` (+11 -0) 📝 `src/Core/Models/View/LoginView.cs` (+0 -13) 📝 `src/iOS.Autofill/Utilities/BaseLoginListTableSource.cs` (+15 -0) 📝 `src/iOS.Core/Utilities/ASHelpers.cs` (+1 -1) 📝 `src/iOS.Core/Views/ExtensionTableSource.cs` (+3 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> If all usernames are null on a cipher item that has passkeys, then `Cipher.Name` should be displayed for username. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CipherView:** Moved method to get the Username and take into account `Cipher.Name` as a possible fallback. * **BaseLoginListTableSource:** Take into account username fallbacks for passkey items. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-11 02:37:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#10175
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?