github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 13:36:39 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1750] [MERGED] [Icons] FF requested icon changes #3095

New Issue
Closed
opened 2025-11-26 23:28:13 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:28:13 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1750
Author: @vincentsalucci
Created: 2/3/2022
Status: ✅ Merged
Merged: 2/3/2022
Merged by: @vincentsalucci

Base: master ← Head: m-ff-icon-changes

📝 Commits (1)

  • 878e3d7 [Icons] Fast follower changes

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 src/App/Pages/Vault/AddEditPage.xaml (+1 -1)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageListItem.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Make any requested icon changes. Merge to both master and rc once approved.

Code changes

  • AddEditPage.xaml: Icon update - refresh - > generate
  • GroupingsPageListItem.cs: Icon update - all folders -> folder

Testing requirements

  • Make sure the classes listed above are working/looking as expected

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1750 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 2/3/2022 **Status:** ✅ Merged **Merged:** 2/3/2022 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `master` ← **Head:** `m-ff-icon-changes` --- ### 📝 Commits (1) - [`878e3d7`](https://github.com/bitwarden/android/commit/878e3d7bfc06173d81994efff1584eed9ad6fbbd) [Icons] Fast follower changes ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/AddEditPage.xaml` (+1 -1) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageListItem.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective > Make any requested icon changes. Merge to both `master` and `rc` once approved. ## Code changes - **AddEditPage.xaml**: Icon update - `refresh` - > `generate` - **GroupingsPageListItem.cs**: Icon update - all folders -> `folder` ## Testing requirements - Make sure the classes listed above are working/looking as expected ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:28:13 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3095
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?