github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2942] [CLOSED] [PM-5760] Add autofill support for Spin Browser #29907

New Issue
Closed
opened 2026-04-18 13:47:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 13:47:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2942
Author: @theRealPadster
Created: 1/17/2024
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (10+)

📊 Changes

3 files changed (+34 additions, -29 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+15 -14)
📝 src/Android/Autofill/AutofillHelpers.cs (+16 -15)
📝 src/Android/Resources/xml/autofillservice.xml (+3 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Bitwarden autofill doesn't work in Spin Browser. More details in this issue: https://github.com/bitwarden/mobile/issues/2848.
Spin Browser is a browser based on Firefox for mobile that adds built-in internet filtering functionality.
Website: https://spinsafebrowser.com
Google Play: https://play.google.com/store/apps/details?id=com.nationaledtech.spinbrowser

Code changes

  • AutofillHelpers.cs: Added "com.nationaledtech.spinbrowser",
  • AccessibilityHelpers.cs: Added new Browser("com.nationaledtech.spinbrowser", "mozac_browser_toolbar_url_view"),
  • autofillservice.xml Added <compatibility-package android:name="com.nationaledtech.spinbrowser" android:maxLongVersionCode="10000000000"/>
  • Some trailing whitespace was also auto-removed from AutofillHelpers.cs and AccessibilityHelpers.cs

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2942 **Author:** [@theRealPadster](https://github.com/theRealPadster) **Created:** 1/17/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (10+) - [`44e5682`](https://github.com/bitwarden/android/commit/44e5682b1d4e34fb81ab5b82eedbc15ff67e17a4) Autosync the updated translations (#2371) - [`e7d6783`](https://github.com/bitwarden/android/commit/e7d67831560af8a9c6d4e4ed9a7a4c0cca13b5ce) [PS-2280] Retain app settings on logout (#2366) - [`bc439b4`](https://github.com/bitwarden/android/commit/bc439b45c987acfd2e9ec7c25a91176b9253fa4d) Bump version to 2023.2.0 (#2374) - [`2321122`](https://github.com/bitwarden/android/commit/2321122e8191f400923c3ae2cadea4d80b707aa7) Bumped version to 2023.2.1 (#2377) - [`8ec6c7f`](https://github.com/bitwarden/android/commit/8ec6c7f0f7809d8c2c8a0033149d034f2bdaf315) Remove dotnet format note (#2378) - [`bf7d9b5`](https://github.com/bitwarden/android/commit/bf7d9b5646003b4faf9b61f8108f77b5a497383a) [SG-1022] Update min password requirements to 12 char (#2368) - [`c5d72ad`](https://github.com/bitwarden/android/commit/c5d72ad7cb264bc725cd687739e93fa3831d2c47) State migration storage key refinement (#2379) - [`0539eda`](https://github.com/bitwarden/android/commit/0539eda57ee00e6fd252259b851cd4185820428f) Autosync the updated translations (#2381) - [`b26b9ea`](https://github.com/bitwarden/android/commit/b26b9ea41b98b9a66954e047d5aad64de782da71) [EC-763] Cake build watchOS (#2278) - [`3f72d35`](https://github.com/bitwarden/android/commit/3f72d3514519b5745ce5a34826c00e60921aadf7) [SG-744] Add claimed domain logic to mobile (#2333) ### 📊 Changes **3 files changed** (+34 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+15 -14) 📝 `src/Android/Autofill/AutofillHelpers.cs` (+16 -15) 📝 `src/Android/Resources/xml/autofillservice.xml` (+3 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [x] Other ## Objective Bitwarden autofill doesn't work in Spin Browser. More details in this issue: https://github.com/bitwarden/mobile/issues/2848. Spin Browser is a browser based on Firefox for mobile that adds built-in internet filtering functionality. Website: https://spinsafebrowser.com Google Play: https://play.google.com/store/apps/details?id=com.nationaledtech.spinbrowser ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AutofillHelpers.cs**: Added `"com.nationaledtech.spinbrowser",` * **AccessibilityHelpers.cs:** Added `new Browser("com.nationaledtech.spinbrowser", "mozac_browser_toolbar_url_view"),` * **autofillservice.xml** Added `<compatibility-package android:name="com.nationaledtech.spinbrowser" android:maxLongVersionCode="10000000000"/>` * Some trailing whitespace was also auto-removed from `AutofillHelpers.cs` and `AccessibilityHelpers.cs` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 13:47:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#29907
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?